305: PR feedback

Signed-off-by: Eddie Seay <[email protected]>
connectrpc · Oct 28, 2024 · dd40511 · dd40511
1 parent 24ae23d
commit dd40511
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 10 deletions.
diff --git a/Plugins/ConnectMocksPlugin/ConnectMockGenerator.swift b/Plugins/ConnectMocksPlugin/ConnectMockGenerator.swift
@@ -229,10 +229,10 @@ private extension MethodDescriptor {
         if self.options.deprecated {
             // swiftlint:disable line_length
             return """
-            @available(iOS, introduced: 12, deprecated: 12, message: "This function has been marked deprecated.")
-            @available(macOS, introduced: 10.15, deprecated: 10.15, message: "This function has been marked deprecated.")
-            @available(tvOS, introduced: 13, deprecated: 13, message: "This function has been marked deprecated.")
-            @available(watchOS, introduced: 6, deprecated: 6, message: "This function has been marked deprecated.")
+            @available(iOS, introduced: 12, deprecated: 12, message: "This RPC has been marked as deprecated in its `.proto` file.")
+            @available(macOS, introduced: 10.15, deprecated: 10.15, message: "This RPC has been marked as deprecated in its `.proto` file.")
+            @available(tvOS, introduced: 13, deprecated: 13, message: "This RPC has been marked as deprecated in its `.proto` file.")
+            @available(watchOS, introduced: 6, deprecated: 6, message: "This RPC has been marked as deprecated in its `.proto` file.")
             """
             // swiftlint:enable line_length
         } else {
@@ -243,7 +243,7 @@ private extension MethodDescriptor {
     func asyncAwaitAvailabilityAnnotation() -> String? {
         if self.options.deprecated {
             // swiftlint:disable:next line_length
-            return "@available(iOS, introduced: 13, deprecated: 13, message: \"This function has been marked deprecated.\")"
+            return "@available(iOS, introduced: 13, deprecated: 13, message: \"This RPC has been marked as deprecated in its `.proto` file.\")"
         } else {
             return nil
         }

diff --git a/Plugins/ConnectSwiftPlugin/ConnectClientGenerator.swift b/Plugins/ConnectSwiftPlugin/ConnectClientGenerator.swift
@@ -211,10 +211,10 @@ private extension MethodDescriptor {
         if self.options.deprecated {
             // swiftlint:disable line_length
             return """
-            @available(iOS, introduced: 12, deprecated: 12, message: "This function has been marked deprecated.")
-            @available(macOS, introduced: 10.15, deprecated: 10.15, message: "This function has been marked deprecated.")
-            @available(tvOS, introduced: 13, deprecated: 13, message: "This function has been marked deprecated.")
-            @available(watchOS, introduced: 6, deprecated: 6, message: "This function has been marked deprecated.")
+            @available(iOS, introduced: 12, deprecated: 12, message: "This RPC has been marked as deprecated in its `.proto` file.")
+            @available(macOS, introduced: 10.15, deprecated: 10.15, message: "This RPC has been marked as deprecated in its `.proto` file.")
+            @available(tvOS, introduced: 13, deprecated: 13, message: "This RPC has been marked as deprecated in its `.proto` file.")
+            @available(watchOS, introduced: 6, deprecated: 6, message: "This RPC has been marked as deprecated in its `.proto` file.")
             """
             // swiftlint:enable line_length
         } else {
@@ -225,7 +225,7 @@ private extension MethodDescriptor {
     func asyncAwaitAvailabilityAnnotation() -> String {
         if self.options.deprecated {
             // swiftlint:disable:next line_length
-            return "@available(iOS, introduced: 13, deprecated: 13, message: \"This function has been marked deprecated.\")"
+            return "@available(iOS, introduced: 13, deprecated: 13, message: \"This RPC has been marked as deprecated in its `.proto` file.\")"
         } else {
             return "@available(iOS 13, *)"
         }