Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Errors page to dart #236

Merged
merged 2 commits into from
Dec 5, 2024
Merged

Add Errors page to dart #236

merged 2 commits into from
Dec 5, 2024

Conversation

srikrsna-buf
Copy link
Member

Add Errors page to dart

Signed-off-by: Sri Krishna <[email protected]>
Copy link

vercel bot commented Dec 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
connect ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 5, 2024 3:41pm

@srikrsna-buf srikrsna-buf requested a review from smaye81 December 5, 2024 03:06

[code]: https://github.com/connectrpc/connect-dart/blob/main/packages/connect/lib/src/code.dart#L22
[exception]: https://github.com/connectrpc/connect-dart/blob/main/packages/connect/lib/src/exception.dart#L30
[headers]: https://github.com/connectrpc/connect-dart/blob/886665eb38e3aad4de81665b4ab83142070c586d/packages/connect/lib/src/headers.dart#L18
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just verifying whether you want to link to main or this specific hash.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I want to link to main for now as the hash will change

Signed-off-by: Sri Krishna <[email protected]>
@srikrsna-buf srikrsna-buf merged commit faa8dbc into dart Dec 5, 2024
3 of 5 checks passed
@srikrsna-buf srikrsna-buf deleted the sk/dart/errors branch December 5, 2024 15:44
srikrsna-buf added a commit that referenced this pull request Dec 19, 2024
Add `Errors` page to dart

---------

Signed-off-by: Sri Krishna <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants