Skip to content

Commit

Permalink
docs helper-programs: add comment about hub_cloud_permissions structure
Browse files Browse the repository at this point in the history
  • Loading branch information
consideRatio committed Apr 19, 2024
1 parent 43c87e5 commit 4391e6c
Showing 1 changed file with 5 additions and 0 deletions.
5 changes: 5 additions & 0 deletions docs/helper-programs/generate-hub-features-table.py
Original file line number Diff line number Diff line change
Expand Up @@ -155,6 +155,11 @@ def parse_terraform_value_files_for_features(terraform_config):
hub_cloud_permissions = terraform_config.get("hub_cloud_permissions", None)
if hub_cloud_permissions:
for hub_slug, permissions in hub_cloud_permissions.items():
# The permission object doesn't have the same structure in AWS
# as for GCP currently, and requestor_pays is only available for
# GCP currently. The logic below works, but needs an update if
# GCP aligns with the same structure as AWS, or if
# requestor_pays config is added for AWS.
features[hub_slug] = {
"user_buckets": True,
"requestor_pays": permissions.get("requestor_pays", False),
Expand Down

0 comments on commit 4391e6c

Please sign in to comment.