From 4391e6c22099ad71c46f299947da9bdedd2cb777 Mon Sep 17 00:00:00 2001 From: Erik Sundell Date: Fri, 19 Apr 2024 15:52:11 +0200 Subject: [PATCH] docs helper-programs: add comment about hub_cloud_permissions structure --- docs/helper-programs/generate-hub-features-table.py | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/docs/helper-programs/generate-hub-features-table.py b/docs/helper-programs/generate-hub-features-table.py index 8e7e1e1e5c..e7b4f275e5 100644 --- a/docs/helper-programs/generate-hub-features-table.py +++ b/docs/helper-programs/generate-hub-features-table.py @@ -155,6 +155,11 @@ def parse_terraform_value_files_for_features(terraform_config): hub_cloud_permissions = terraform_config.get("hub_cloud_permissions", None) if hub_cloud_permissions: for hub_slug, permissions in hub_cloud_permissions.items(): + # The permission object doesn't have the same structure in AWS + # as for GCP currently, and requestor_pays is only available for + # GCP currently. The logic below works, but needs an update if + # GCP aligns with the same structure as AWS, or if + # requestor_pays config is added for AWS. features[hub_slug] = { "user_buckets": True, "requestor_pays": permissions.get("requestor_pays", False),