Skip to content

Commit 226ec73

Browse files
committed
Mark VolumeExpansion capability in PluginCapability deprecated
1 parent 4b1c7a3 commit 226ec73

File tree

3 files changed

+267
-234
lines changed

3 files changed

+267
-234
lines changed

csi.proto

+16-2
Original file line numberDiff line numberDiff line change
@@ -185,6 +185,10 @@ message PluginCapability {
185185
Type type = 1;
186186
}
187187

188+
// Deprecated - Ability for a plugin to delcare online and offline
189+
// controller expansion capabilities via PluginCapability
190+
// is deprecated. A plugin may support either mode of operation
191+
// without having to declare them in PluginCapability.
188192
message VolumeExpansion {
189193
enum Type {
190194
UNKNOWN = 0;
@@ -234,8 +238,18 @@ message PluginCapability {
234238
oneof type {
235239
// Service that the plugin supports.
236240
Service service = 1;
237-
// deprecated
238-
VolumeExpansion volume_expansion = 2;
241+
// Deprecated - Ability for a plugin to delcare online and offline
242+
// controller expansion capabilities via PluginCapability
243+
// is deprecated. A plugin may support either mode of operation
244+
// without having to declare them in PluginCapability.
245+
//
246+
// If set a CO will ignore ONLINE and OFFLINE capabilities
247+
// specified in PluginCapability.
248+
// If a plugin can not support controller expansion of published
249+
// and available volumes on a node - it may return
250+
// FAILED_PRECONDITION error and CO should ensure that volume
251+
// is not published before retrying with exponential backoff.
252+
VolumeExpansion volume_expansion = 2 [deprecated=true];
239253
}
240254
}
241255
message ProbeRequest {

0 commit comments

Comments
 (0)