Skip to content

Commit 7574213

Browse files
committed
Address spelling/grammar errors
1 parent 3f7aeca commit 7574213

File tree

3 files changed

+17
-17
lines changed

3 files changed

+17
-17
lines changed

csi.proto

+5-5
Original file line numberDiff line numberDiff line change
@@ -764,7 +764,7 @@ message ControllerUnpublishVolumeRequest {
764764
// section on how to use this field.
765765
map<string, string> secrets = 3 [(csi_secret) = true];
766766

767-
// Indicates SP MUST make the volume inacessible to the node or nodes
767+
// Indicates SP MUST make the volume inaccessible to the node or nodes
768768
// it is being unpublished from. Any attempt to read or write data
769769
// to a volume from a node that has been fenced MUST NOT succeed,
770770
// even if the volume remains staged and/or published on the node.
@@ -1505,10 +1505,10 @@ message NodeServiceCapability {
15051505
// Note that, for alpha, `VolumeCondition` is intended to be
15061506
// informative for humans only, not for automation.
15071507
VOLUME_CONDITION = 4 [(alpha_enum_value) = true];
1508-
// Indicates that the node supports the NodeUnpublishVolume.force
1509-
// field. Also indicates that the node supports the
1510-
// NodeUnstageVolume.force field if it also has the
1511-
// STAGE_UNSTAGE_VOLUME capability.
1508+
// Indicates that the Node Plugin supports the
1509+
// NodeUnpublishVolume.force field. Also indicates that the
1510+
// Node Plugin supports the NodeUnstageVolume.force field if
1511+
// it also has the STAGE_UNSTAGE_VOLUME capability.
15121512
FORCE_UNPUBLISH = 5 [(alpha_enum_value) = true];
15131513
}
15141514

lib/go/csi/csi.pb.go

+3-3
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

spec.md

+9-9
Original file line numberDiff line numberDiff line change
@@ -1338,7 +1338,7 @@ message ControllerUnpublishVolumeRequest {
13381338
// section on how to use this field.
13391339
map<string, string> secrets = 3 [(csi_secret) = true];
13401340
1341-
// Indicates SP MUST make the volume inacessible to the node or nodes
1341+
// Indicates SP MUST make the volume inaccessible to the node or nodes
13421342
// it is being unpublished from. Any attempt to read or write data
13431343
// to a volume from a node that has been fenced MUST NOT succeed,
13441344
// even if the volume remains staged and/or published on the node.
@@ -2195,8 +2195,8 @@ If the corresponding Controller Plugin has `PUBLISH_UNPUBLISH_VOLUME` controller
21952195
The CO MUST guarantee that this RPC is called after all `NodeUnpublishVolume` have been called and returned success for the given volume on the given node.
21962196

21972197
If the Node Plugin has the `FORCE_UNPUBLISH` capability, the CO MAY specify `force` as `true` in which case the Node Plugin MUST support unstaging volumes even when access has been revoked with `ControllerUnpublishVolume`.
2198-
Because data loss is inevitable in such circumstances, the `force` flag is an indication that success is desired even it if means losing data.
2199-
It is essential that after a successful call to `NodeUnstageVolume` that there be no buffered data on the node related to the volume which might result in unintetional modification of the volume if it were to be subsequently re-staged to that node.
2198+
Because data loss is inevitable in such circumstances, the `force` flag is an indication that success is desired even if it means losing data.
2199+
It is essential that after a successful call to `NodeUnstageVolume` that there will be no buffered data on the node related to the volume which might result in unintentional modification of the volume if it was to be subsequently re-staged to that node.
22002200

22012201
The Plugin SHALL assume that this RPC will be executed on the node where the volume is being used.
22022202

@@ -2368,8 +2368,8 @@ If the corresponding Controller Plugin has `PUBLISH_UNPUBLISH_VOLUME` controller
23682368
The Plugin SHALL assume that this RPC will be executed on the node where the volume is being used.
23692369

23702370
If the Node Plugin has the `FORCE_UNPUBLISH` capability, the CO MAY specify `force` as `true` in which case the Node Plugin MUST support unpublishing volumes even when access has been revoked with `ControllerUnpublishVolume`.
2371-
Because data loss is inevitable in such circumstances, the `force` flag is an indication that success is desired even it if means losing data.
2372-
It is essential that after a successful call to `NodeUnpublishVolume` that there be no buffered data on the node related to the volume which might result in unintetional modification of the volume if it were to be subsequently re-published to that node.
2371+
Because data loss is inevitable in such circumstances, the `force` flag is an indication that success is desired even if it means losing data.
2372+
It is essential that after a successful call to `NodeUnpublishVolume` that there will be no buffered data on the node related to the volume which might result in unintetional modification of the volume if it was to be subsequently re-published to that node.
23732373

23742374
This RPC is typically called by the CO when the workload using the volume is being moved to a different node, or all the workload using the volume on a node has finished.
23752375

@@ -2553,10 +2553,10 @@ message NodeServiceCapability {
25532553
// Note that, for alpha, `VolumeCondition` is intended to be
25542554
// informative for humans only, not for automation.
25552555
VOLUME_CONDITION = 4 [(alpha_enum_value) = true];
2556-
// Indicates that the node supports the NodeUnpublishVolume.force
2557-
// field. Also indicates that the node supports the
2558-
// NodeUnstageVolume.force field if it also has the
2559-
// STAGE_UNSTAGE_VOLUME capability.
2556+
// Indicates that the Node Plugin supports the
2557+
// NodeUnpublishVolume.force field. Also indicates that the
2558+
// Node Plugin supports the NodeUnstageVolume.force field if
2559+
// it also has the STAGE_UNSTAGE_VOLUME capability.
25602560
FORCE_UNPUBLISH = 5 [(alpha_enum_value) = true];
25612561
}
25622562

0 commit comments

Comments
 (0)