Skip to content

Commit f1ae024

Browse files
authored
Merge pull request #468 from gnufied/add-gid-publish
Add spec change for volume mount group
2 parents 0cedd1b + 3715e5f commit f1ae024

File tree

3 files changed

+307
-239
lines changed

3 files changed

+307
-239
lines changed

csi.proto

+20-1
Original file line numberDiff line numberDiff line change
@@ -395,6 +395,19 @@ message VolumeCapability {
395395
// to untrusted entities. The total size of this repeated field
396396
// SHALL NOT exceed 4 KiB.
397397
repeated string mount_flags = 2;
398+
399+
// If SP has VOLUME_MOUNT_GROUP node capability and CO provides
400+
// this field then SP MUST ensure that the volume_mount_group
401+
// parameter is passed as the group identifier to the underlying
402+
// operating system mount system call, with the understanding
403+
// that the set of available mount call parameters and/or
404+
// mount implementations may vary across operating systems.
405+
// Additionally, new file and/or directory entries written to
406+
// the underlying filesystem SHOULD be permission-labeled in such a
407+
// manner, unless otherwise modified by a workload, that they are
408+
// both readable and writable by said mount group identifier.
409+
// This is an OPTIONAL field.
410+
string volume_mount_group = 3 [(alpha_field) = true];
398411
}
399412

400413
// Specify how a volume can be accessed.
@@ -1498,6 +1511,7 @@ message NodeServiceCapability {
14981511
// Note that, for alpha, `VolumeCondition` is intended to be
14991512
// informative for humans only, not for automation.
15001513
VOLUME_CONDITION = 4 [(alpha_enum_value) = true];
1514+
15011515
// Indicates the SP supports the SINGLE_NODE_SINGLE_WRITER and/or
15021516
// SINGLE_NODE_MULTI_WRITER access modes.
15031517
// These access modes are intended to replace the
@@ -1508,6 +1522,11 @@ message NodeServiceCapability {
15081522
// SINGLE_NODE_SINGLE_WRITER and/or SINGLE_NODE_MULTI_WRITER are
15091523
// supported, in order to permit older COs to continue working.
15101524
SINGLE_NODE_MULTI_WRITER = 5 [(alpha_enum_value) = true];
1525+
1526+
// Indicates that Node service supports mounting volumes
1527+
// with provided volume group identifier during node stage
1528+
// or node publish RPC calls.
1529+
VOLUME_MOUNT_GROUP = 6 [(alpha_enum_value) = true];
15111530
}
15121531

15131532
Type type = 1;
@@ -1606,7 +1625,7 @@ message NodeExpandVolumeRequest {
16061625
// Secrets required by plugin to complete node expand volume request.
16071626
// This field is OPTIONAL. Refer to the `Secrets Requirements`
16081627
// section on how to use this field.
1609-
map<string, string> secrets = 6
1628+
map<string, string> secrets = 6
16101629
[(csi_secret) = true, (alpha_field) = true];
16111630
}
16121631

0 commit comments

Comments
 (0)