-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
install: Automatically set up bind mounts if not provided #919
base: main
Are you sure you want to change the base?
Conversation
Tested with this patch to podman-bootc:
|
One thing I will say I'm pretty proud of is this code almost worked the first try, including the whole fd passing over the socketpair. The famous "in Rust if it compiles, it works". The only thing I missed was that for |
|
b212029
to
0cf5516
Compare
Title is outdated |
The PR title? Updated. |
Hmm, so one job failed like this:
Which looks like it could be caused by this PR, but I don't have any idea why it would just silently not work there...what I was thinking could fail is if we were running from an older OS without the new mount API but I think all operating system versions we care about right now have it. I have no idea how to rerun testing farm jobs to see if this was a flake... |
Amend force to rerun all? |
We're looking again at the ergonomics of `bootc install to-existing-root`. This uses the "mounting into mount namespaces" from the new mount API to automatically set up `/dev` and `/var/lib/containers` if they weren't provided to `podman run`, which shrinks what's needed a bit. Closes: containers#826 Signed-off-by: Colin Walters <[email protected]>
Now that we unconditionally mount /var/lib/containers, drop the hacky fork-skopeo-in-host-mountns code. Signed-off-by: Colin Walters <[email protected]>
Keep the bind mounts in the docs though for now because many people will be using the current docs with older bootc. Signed-off-by: Colin Walters <[email protected]>
Build on our new logic for bind mounting from the host mountns to also drop the need for the `-v /:/target` in the alongside install code. Signed-off-by: Colin Walters <[email protected]>
Hooray for `const`. Signed-off-by: Colin Walters <[email protected]>
These should be unnecessary. Signed-off-by: Colin Walters <[email protected]>
3ae2a4d
to
3261203
Compare
install: Automatically set up /dev and /var/lib/containers
We're looking again at the ergonomics of
bootc install to-existing-root
.This uses the "mounting into mount namespaces" from the new
mount API to automatically set up
/dev
and/var/lib/containers
if they weren't provided to
podman run
, which shrinks what'sneeded a bit.
Closes: #826
Signed-off-by: Colin Walters [email protected]
install: Drop skopeo-in-host fallback code
Now that we unconditionally mount /var/lib/containers, drop
the hacky fork-skopeo-in-host-mountns code.
Signed-off-by: Colin Walters [email protected]
Drop test references to /dev and /var/lib/containers mounts
Keep the bind mounts in the docs though for now because many
people will be using the current docs with older bootc.
Signed-off-by: Colin Walters [email protected]
install: Drop need for -v /:/target
Build on our new logic for bind mounting from the host mountns
to also drop the need for the
-v /:/target
in the alongsideinstall code.
Signed-off-by: Colin Walters [email protected]
install: Centralize PID1 definition
Hooray for
const
.Signed-off-by: Colin Walters [email protected]
tests: Drop more bind mount instances
These should be unnecessary.
Signed-off-by: Colin Walters [email protected]