Broke warn_on_host_root
#907
Labels
area/install
Issues related to `bootc install`
Comments
|
The solution would be to use the original user provided |
|
I will wait for #905 to merge before pushing a fix, as they're surely going to conflict. |
omertuc
added a commit
to omertuc/bootc
that referenced
this issue
Nov 19, 2024
The `warn_on_host_root` check was broken when we added support for installing on already-ostree systems. See containers#907 The solution is to use the original user provided root_path for the fd passed to warn_on_host_root, rather than the modified one, as that will always match /proc/0/root's fsid (in ostree systems systemd is running with the deployment root as its root, and this is what we have mounted as /:/target) Signed-off-by: Omer Tuchfeld <[email protected]>
omertuc
added a commit
to omertuc/bootc
that referenced
this issue
Nov 25, 2024
The `warn_on_host_root` check was broken when we added support for installing on already-ostree systems (but only for already-ostree systems). See containers#907 The solution is to use the original user provided root_path for the fd passed to warn_on_host_root, rather than the modified one, as that will always match /proc/0/root's fsid (in ostree systems systemd is running with the deployment root as its root, and this is what we have mounted as /:/target) Signed-off-by: Omer Tuchfeld <[email protected]>
|
I think this is fixed? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
With #137
warn_on_host_rootis brokenRunning command
sudo podman run -it --rm --privileged -v /dev:/dev -v /var/lib/containers:/var/lib/containers -v /:/target --pid=host --security-opt label=type:unconfined_t -e RUST_LOG=trace quay.io/otuchfel/bootc:latest bash -c 'diff <(stat -f -c %i /target/sysroot) <(stat -f -c %i /proc/1/root/) --side-by-side`On a bootc booted system
On a normal system
(slightly modified to look at
/targetrather than/target/sysrootwhich is what bootc will do)On FCOS
The text was updated successfully, but these errors were encountered: