install: Drop code/test uses of --security-opt
#930
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We're looking again at the ergonomics of `bootc install to-existing-root`. This uses the "mounting into mount namespaces" from the new mount API to automatically set up `/dev` and `/var/lib/containers` if they weren't provided to `podman run`, which shrinks what's needed a bit. Closes: containers#826 Signed-off-by: Colin Walters <[email protected]>
Now that we unconditionally mount /var/lib/containers, drop the hacky fork-skopeo-in-host-mountns code. Signed-off-by: Colin Walters <[email protected]>
Keep the bind mounts in the docs though for now because many people will be using the current docs with older bootc. Signed-off-by: Colin Walters <[email protected]>
Build on our new logic for bind mounting from the host mountns to also drop the need for the `-v /:/target` in the alongside install code. Signed-off-by: Colin Walters <[email protected]>
Hooray for `const`. Signed-off-by: Colin Walters <[email protected]>
These should be unnecessary. Signed-off-by: Colin Walters <[email protected]>
We think this is unnecessary now; part of improving the ergonomics of `bootc install` in general, but especially with the `to-existing-root` path. Once this lands, at some point later then we can also remove it from all of the documentation. But the most safe thing is to leave it in the docs for a bit longer. Closes: containers#928 Signed-off-by: Colin Walters <[email protected]>
|
Depends on #919 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We think this is unnecessary now; part of improving
the ergonomics of
bootc installin general, butespecially with the
to-existing-rootpath.Once this lands, at some point later then we
can also remove it from all of the documentation.
But the most safe thing is to leave it in the
docs for a bit longer.
Closes: #928