Switch inplace #264
Merged
Switch inplace #264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This logic just converts the provided CLI options into data structures, so it can come before we do other things. Prep for further work. Signed-off-by: Colin Walters <[email protected]>
I want this in a followup patch. Signed-off-by: Colin Walters <[email protected]>
This is intended to be runnable in current Anaconda `%post` to fix up its lack of support for `--target-imgref`. Signed-off-by: Colin Walters <[email protected]>
|
I haven't yet tried this in an anaconda |
|
Yep, tested in Anaconda |
|
Awesome, thank you. I'll be using this for osbuild/images#380 |
ondrejbudai
approved these changes
Jan 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
switch: Move option processing earlier
This logic just converts the provided CLI options
into data structures, so it can come before we do
other things.
Prep for further work.
Signed-off-by: Colin Walters [email protected]
spec: impl Display for ImageReference
I want this in a followup patch.
Signed-off-by: Colin Walters [email protected]
switch: Add hidden
--mutate-in-placeThis is intended to be runnable in current Anaconda
%postto fix up its lack of support for
--target-imgref.Signed-off-by: Colin Walters [email protected]