Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filesystem doc #951

Merged
merged 4 commits into from
Dec 10, 2024
Merged

Filesystem doc #951

merged 4 commits into from
Dec 10, 2024

Conversation

cgwalters
Copy link
Collaborator

@cgwalters cgwalters commented Dec 9, 2024

filesystem: Doc usr/etc

Came up in review.

Signed-off-by: Colin Walters [email protected]


filesystem: Doc etc.transient

I noticed this was missing.

Signed-off-by: Colin Walters [email protected]


doc: Expand on prepare-root

Per review.

Signed-off-by: Colin Walters [email protected]


Copy link
Member

@vrothberg vrothberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
Just two tiny nits

docs/src/filesystem.md Outdated Show resolved Hide resolved
docs/src/filesystem.md Outdated Show resolved Hide resolved
Came up in review.

Signed-off-by: Colin Walters <[email protected]>
I noticed this was missing.

Signed-off-by: Colin Walters <[email protected]>
Per review.

Signed-off-by: Colin Walters <[email protected]>
docs/src/filesystem.md Outdated Show resolved Hide resolved
Copy link
Member

@vrothberg vrothberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!
Just one typo. Feel free to merge after.

My fingers apparently want to do the wrong thing here

Signed-off-by: Colin Walters <[email protected]>
@cgwalters
Copy link
Collaborator Author

Feel free to merge after.

At a technical level today this repo requires an official GH approval to merge

Copy link
Contributor

@jeckersb jeckersb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I put on my @vrothberg disguise and approve 😆

@cgwalters cgwalters merged commit f943d07 into containers:main Dec 10, 2024
25 checks passed
@vrothberg
Copy link
Member

Thanks, @jeckersb! My calendar is a mess this week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants