Remove the restriction on gix-url < 2.5.1 #571
Comments
facebook-github-bot
pushed a commit
to facebookexperimental/rust-shed
that referenced
this issue
Aug 28, 2024
Summary: This is to make it easier to get GitoxideLabs/gitoxide#1543 once it's released upstream. There was an uncompatibility between `c2pa` which requires an older version of `url` as they want to have lawyers check the Unicode 3.0 license and `gix-url` which required latest `url` to support the nightly compiler. I "resolved" it by removing the restriction from `c2pa` and pointing at that for now. I also raised an issue upstream: contentauth/c2pa-rs#571 to bring it back to their awareness, so hopefully we can move off my fork soon enough. Reviewed By: YousefSalama, dtolnay Differential Revision: D57676392 fbshipit-source-id: fc5cabc860de9200abf3fe1145a3dbdef2a96efa
facebook-github-bot
pushed a commit
to facebookincubator/reindeer
that referenced
this issue
Aug 28, 2024
Summary: This is to make it easier to get GitoxideLabs/gitoxide#1543 once it's released upstream. There was an uncompatibility between `c2pa` which requires an older version of `url` as they want to have lawyers check the Unicode 3.0 license and `gix-url` which required latest `url` to support the nightly compiler. I "resolved" it by removing the restriction from `c2pa` and pointing at that for now. I also raised an issue upstream: contentauth/c2pa-rs#571 to bring it back to their awareness, so hopefully we can move off my fork soon enough. Reviewed By: YousefSalama, dtolnay Differential Revision: D57676392 fbshipit-source-id: fc5cabc860de9200abf3fe1145a3dbdef2a96efa
facebook-github-bot
pushed a commit
to facebook/dotslash
that referenced
this issue
Aug 28, 2024
Summary: This is to make it easier to get GitoxideLabs/gitoxide#1543 once it's released upstream. There was an uncompatibility between `c2pa` which requires an older version of `url` as they want to have lawyers check the Unicode 3.0 license and `gix-url` which required latest `url` to support the nightly compiler. I "resolved" it by removing the restriction from `c2pa` and pointing at that for now. I also raised an issue upstream: contentauth/c2pa-rs#571 to bring it back to their awareness, so hopefully we can move off my fork soon enough. Reviewed By: YousefSalama, dtolnay Differential Revision: D57676392 fbshipit-source-id: fc5cabc860de9200abf3fe1145a3dbdef2a96efa
facebook-github-bot
pushed a commit
to facebook/sapling
that referenced
this issue
Aug 28, 2024
Summary: This is to make it easier to get GitoxideLabs/gitoxide#1543 once it's released upstream. There was an uncompatibility between `c2pa` which requires an older version of `url` as they want to have lawyers check the Unicode 3.0 license and `gix-url` which required latest `url` to support the nightly compiler. I "resolved" it by removing the restriction from `c2pa` and pointing at that for now. I also raised an issue upstream: contentauth/c2pa-rs#571 to bring it back to their awareness, so hopefully we can move off my fork soon enough. Reviewed By: YousefSalama, dtolnay Differential Revision: D57676392 fbshipit-source-id: fc5cabc860de9200abf3fe1145a3dbdef2a96efa
scouten-adobe
added a commit
that referenced
this issue
Aug 29, 2024
Should fix #571. (Unfamiliar license and MSRV change added in 2.5.1 has been reverted.)
|
@pierrechevalier83 the license and MSRV changes in url 2.5.1 (note: url crate, not gix-url) were problematic for us and apparently many others. Just became aware that the changes were reverted, which makes things a lot easier for us. (See discussion here: servo/rust-url#937.) We just released c2pa-rs version 0.33.4. This version now requires 2.5.2 or newer and hopefully should resolve your issues. |
facebook-github-bot
pushed a commit
to facebook/hhvm
that referenced
this issue
Sep 11, 2024
Summary: This is to make it easier to get GitoxideLabs/gitoxide#1543 once it's released upstream. There was an uncompatibility between `c2pa` which requires an older version of `url` as they want to have lawyers check the Unicode 3.0 license and `gix-url` which required latest `url` to support the nightly compiler. I "resolved" it by removing the restriction from `c2pa` and pointing at that for now. I also raised an issue upstream: contentauth/c2pa-rs#571 to bring it back to their awareness, so hopefully we can move off my fork soon enough. Reviewed By: YousefSalama, dtolnay Differential Revision: D57676392 fbshipit-source-id: fc5cabc860de9200abf3fe1145a3dbdef2a96efa
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
gix-url was locked to be under 2.5.1 in June: 69ae6aa
The commit message states:
I thought I would make a tracking issue for this so I can be notified when this review has taken place and the block is removed.
In the meantime, it is complicated to depend on this and other crates like
gix-urlwhich require2.5.2or above for compatibility with the nightly compiler.The text was updated successfully, but these errors were encountered: