Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RichTextViewController.preferredContentSize is not always updated correctly #67

Open
bebroll opened this issue Nov 19, 2023 · 1 comment
Open

RichTextViewController.preferredContentSize is not always updated correctly #67

bebroll opened this issue Nov 19, 2023 · 1 comment

Comments

@bebroll
Copy link

bebroll commented Nov 19, 2023

In one of our SwiftUI-based projects, we've noticed that RichTextViewController is dispatching several rendering steps async using the main DispatchQueue. Due to this, calculating and setting the RichTextViewController.preferredContentSize property will not take these rendering steps (and their influence on the UITextView) into consideration.

The change that we propose in the following PR fixed the issue for us:

aasatt#1
@mariuskatcontentful
Copy link
Collaborator

Hello!

I have merged the changes from original fork and your PR into the latest repo in this branch

https://github.com/contentful/rich-text-renderer.swift/tree/chore/swift-ui-compatibility

Could you confirm this is working as you expect?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mariuskatcontentful @bebroll