From e3a3637748b8dbc19915097387b7037ae0681594 Mon Sep 17 00:00:00 2001
From: Jayesh Deorukhkar <jddeorukhkar@gmail.com>
Date: Wed, 8 Nov 2023 16:10:18 +0530
Subject: [PATCH] fix: remove float from imaage tag for image type assets

---
 src/toRedactor.tsx  | 6 +++---
 test/testingData.ts | 8 ++++----
 2 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/src/toRedactor.tsx b/src/toRedactor.tsx
index d5f2d6e..829a7d8 100644
--- a/src/toRedactor.tsx
+++ b/src/toRedactor.tsx
@@ -456,9 +456,9 @@ export const toRedactor = (jsonValue: any,options?:IJsonToHtmlOptions) : string
               styleObj["width"] = "auto";
             }
             delete styleObj["float"];
-            (attrsJson["style"] && typeof attrsJson["style"] === 'string')
-              ? (attrsJson["style"] += getStyleStringFromObject(styleObj))
-              : (attrsJson["style"] = getStyleStringFromObject(styleObj));
+            // (attrsJson["style"] && typeof attrsJson["style"] === 'string')
+            //   ? (attrsJson["style"] += getStyleStringFromObject(styleObj)) :
+            (attrsJson["style"] = getStyleStringFromObject(styleObj));
           }
           delete attrsJson['display-type']
         }
diff --git a/test/testingData.ts b/test/testingData.ts
index 7f5b96a..ba4bf23 100644
--- a/test/testingData.ts
+++ b/test/testingData.ts
@@ -178,7 +178,7 @@ export const imageAssetData = {
         ],
       },
     ]),
-    expectedHtml: `<figure style="margin: 0; text-align: left"><img src="https://images.contentstack.io/v3/assets/blt90bbfcce23680d08/bltb87e0bd5764c421e/64abd49b7b26dfaeede17525/batman.png" class="embedded-asset" content-type-uid="sys_assets" type="asset" style="text-align: left;max-width: undefinedpx;float: left;text-align: left; max-width: undefinedpx; width: auto" data-sys-asset-filelink="https://images.contentstack.io/v3/assets/blt90bbfcce23680d08/bltb87e0bd5764c421e/64abd49b7b26dfaeede17525/batman.png" data-sys-asset-uid="bltb87e0bd5764c421e" data-sys-asset-filename="batman.png" data-sys-asset-contenttype="image/png" data-sys-asset-position="left" sys-style-type="display"/></figure><figure style="margin: 0; text-align: right"><img src="https://images.contentstack.io/v3/assets/blt90bbfcce23680d08/bltb87e0bd5764c421e/64abd49b7b26dfaeede17525/batman.png" class="embedded-asset" content-type-uid="sys_assets" type="asset" style="text-align: right;max-width: undefinedpx;float: right;text-align: right; max-width: undefinedpx; width: auto" data-sys-asset-filelink="https://images.contentstack.io/v3/assets/blt90bbfcce23680d08/bltb87e0bd5764c421e/64abd49b7b26dfaeede17525/batman.png" data-sys-asset-uid="bltb87e0bd5764c421e" data-sys-asset-filename="batman.png" data-sys-asset-contenttype="image/png" data-sys-asset-position="right" sys-style-type="display"/></figure><figure style="margin: 0; text-align: center"><img src="https://images.contentstack.io/v3/assets/blt90bbfcce23680d08/bltb87e0bd5764c421e/64abd49b7b26dfaeede17525/batman.png" class="embedded-asset" content-type-uid="sys_assets" type="asset" style="text-align: center;text-align: center; width: auto" data-sys-asset-filelink="https://images.contentstack.io/v3/assets/blt90bbfcce23680d08/bltb87e0bd5764c421e/64abd49b7b26dfaeede17525/batman.png" data-sys-asset-uid="bltb87e0bd5764c421e" data-sys-asset-filename="batman.png" data-sys-asset-contenttype="image/png" data-sys-asset-position="center" sys-style-type="display"/></figure>`,
+    expectedHtml: `<figure style="margin: 0; text-align: left"><img src="https://images.contentstack.io/v3/assets/blt90bbfcce23680d08/bltb87e0bd5764c421e/64abd49b7b26dfaeede17525/batman.png" class="embedded-asset" content-type-uid="sys_assets" type="asset" style="text-align: left; max-width: undefinedpx; width: auto" data-sys-asset-filelink="https://images.contentstack.io/v3/assets/blt90bbfcce23680d08/bltb87e0bd5764c421e/64abd49b7b26dfaeede17525/batman.png" data-sys-asset-uid="bltb87e0bd5764c421e" data-sys-asset-filename="batman.png" data-sys-asset-contenttype="image/png" data-sys-asset-position="left" sys-style-type="display"/></figure><figure style="margin: 0; text-align: right"><img src="https://images.contentstack.io/v3/assets/blt90bbfcce23680d08/bltb87e0bd5764c421e/64abd49b7b26dfaeede17525/batman.png" class="embedded-asset" content-type-uid="sys_assets" type="asset" style="text-align: right; max-width: undefinedpx; width: auto" data-sys-asset-filelink="https://images.contentstack.io/v3/assets/blt90bbfcce23680d08/bltb87e0bd5764c421e/64abd49b7b26dfaeede17525/batman.png" data-sys-asset-uid="bltb87e0bd5764c421e" data-sys-asset-filename="batman.png" data-sys-asset-contenttype="image/png" data-sys-asset-position="right" sys-style-type="display"/></figure><figure style="margin: 0; text-align: center"><img src="https://images.contentstack.io/v3/assets/blt90bbfcce23680d08/bltb87e0bd5764c421e/64abd49b7b26dfaeede17525/batman.png" class="embedded-asset" content-type-uid="sys_assets" type="asset" style="text-align: center; width: auto" data-sys-asset-filelink="https://images.contentstack.io/v3/assets/blt90bbfcce23680d08/bltb87e0bd5764c421e/64abd49b7b26dfaeede17525/batman.png" data-sys-asset-uid="bltb87e0bd5764c421e" data-sys-asset-filename="batman.png" data-sys-asset-contenttype="image/png" data-sys-asset-position="center" sys-style-type="display"/></figure>`,
   },
   anchor: {
     value: getDoc([
@@ -394,7 +394,7 @@ export const imageAssetData = {
         ],
       },
     ]),
-    expectedHtml: `<figure style="margin: 0"><div style="display: inline-block"><a href="https://www.batman.com" target="_blank"><img src="https://images.contentstack.io/v3/assets/blt90bbfcce23680d08/bltb87e0bd5764c421e/64abd49b7b26dfaeede17525/batman.png" alt="I am BATMAN" caption="BATMAN" anchorLink="https://www.batman.com" class="embedded-asset" content-type-uid="sys_assets" type="asset" asset-alt="I am BATMAN" style="width: auto" data-sys-asset-filelink="https://images.contentstack.io/v3/assets/blt90bbfcce23680d08/bltb87e0bd5764c421e/64abd49b7b26dfaeede17525/batman.png" data-sys-asset-uid="bltb87e0bd5764c421e" data-sys-asset-filename="batman.png" data-sys-asset-contenttype="image/png" data-sys-asset-caption="BATMAN" data-sys-asset-alt="I am BATMAN" data-sys-asset-link="https://www.batman.com" data-sys-asset-position="none" data-sys-asset-isnewtab="true" sys-style-type="display"/></a><figcaption style="text-align:center">BATMAN</figcaption></div></figure><figure style="margin: 0; text-align: left"><div style="display: inline-block"><a href="https://www.batman.com" target="_blank"><img src="https://images.contentstack.io/v3/assets/blt90bbfcce23680d08/bltb87e0bd5764c421e/64abd49b7b26dfaeede17525/batman.png" alt="I am BATMAN" caption="BATMAN" anchorLink="https://www.batman.com" class="embedded-asset" content-type-uid="sys_assets" type="asset" asset-alt="I am BATMAN" style="text-align: left;max-width: undefinedpx;float: left;text-align: left; max-width: undefinedpx; width: auto" data-sys-asset-filelink="https://images.contentstack.io/v3/assets/blt90bbfcce23680d08/bltb87e0bd5764c421e/64abd49b7b26dfaeede17525/batman.png" data-sys-asset-uid="bltb87e0bd5764c421e" data-sys-asset-filename="batman.png" data-sys-asset-contenttype="image/png" data-sys-asset-caption="BATMAN" data-sys-asset-alt="I am BATMAN" data-sys-asset-link="https://www.batman.com" data-sys-asset-position="left" data-sys-asset-isnewtab="true" sys-style-type="display"/></a><figcaption style="text-align:center">BATMAN</figcaption></div></figure><figure style="margin: 0; text-align: center"><div style="display: inline-block"><a href="https://www.batman.com" target="_blank"><img src="https://images.contentstack.io/v3/assets/blt90bbfcce23680d08/bltb87e0bd5764c421e/64abd49b7b26dfaeede17525/batman.png" alt="I am BATMAN" caption="BATMAN" anchorLink="https://www.batman.com" class="embedded-asset" content-type-uid="sys_assets" type="asset" asset-alt="I am BATMAN" style="text-align: center;max-width: undefinedpx;float: left;text-align: center; max-width: undefinedpx; width: auto" data-sys-asset-filelink="https://images.contentstack.io/v3/assets/blt90bbfcce23680d08/bltb87e0bd5764c421e/64abd49b7b26dfaeede17525/batman.png" data-sys-asset-uid="bltb87e0bd5764c421e" data-sys-asset-filename="batman.png" data-sys-asset-contenttype="image/png" data-sys-asset-caption="BATMAN" data-sys-asset-alt="I am BATMAN" data-sys-asset-link="https://www.batman.com" data-sys-asset-position="center" data-sys-asset-isnewtab="true" sys-style-type="display"/></a><figcaption style="text-align:center">BATMAN</figcaption></div></figure><figure style="margin: 0; text-align: right"><div style="display: inline-block"><a href="https://www.batman.com" target="_blank"><img src="https://images.contentstack.io/v3/assets/blt90bbfcce23680d08/bltb87e0bd5764c421e/64abd49b7b26dfaeede17525/batman.png" alt="I am BATMAN" caption="BATMAN" anchorLink="https://www.batman.com" class="embedded-asset" content-type-uid="sys_assets" type="asset" asset-alt="I am BATMAN" style="text-align: right;max-width: undefinedpx;float: right;text-align: right; max-width: undefinedpx; width: auto" data-sys-asset-filelink="https://images.contentstack.io/v3/assets/blt90bbfcce23680d08/bltb87e0bd5764c421e/64abd49b7b26dfaeede17525/batman.png" data-sys-asset-uid="bltb87e0bd5764c421e" data-sys-asset-filename="batman.png" data-sys-asset-contenttype="image/png" data-sys-asset-caption="BATMAN" data-sys-asset-alt="I am BATMAN" data-sys-asset-link="https://www.batman.com" data-sys-asset-position="right" data-sys-asset-isnewtab="true" sys-style-type="display"/></a><figcaption style="text-align:center">BATMAN</figcaption></div></figure>`,
+    expectedHtml: `<figure style="margin: 0"><div style="display: inline-block"><a href="https://www.batman.com" target="_blank"><img src="https://images.contentstack.io/v3/assets/blt90bbfcce23680d08/bltb87e0bd5764c421e/64abd49b7b26dfaeede17525/batman.png" alt="I am BATMAN" caption="BATMAN" anchorLink="https://www.batman.com" class="embedded-asset" content-type-uid="sys_assets" type="asset" asset-alt="I am BATMAN" style="width: auto" data-sys-asset-filelink="https://images.contentstack.io/v3/assets/blt90bbfcce23680d08/bltb87e0bd5764c421e/64abd49b7b26dfaeede17525/batman.png" data-sys-asset-uid="bltb87e0bd5764c421e" data-sys-asset-filename="batman.png" data-sys-asset-contenttype="image/png" data-sys-asset-caption="BATMAN" data-sys-asset-alt="I am BATMAN" data-sys-asset-link="https://www.batman.com" data-sys-asset-position="none" data-sys-asset-isnewtab="true" sys-style-type="display"/></a><figcaption style="text-align:center">BATMAN</figcaption></div></figure><figure style="margin: 0; text-align: left"><div style="display: inline-block"><a href="https://www.batman.com" target="_blank"><img src="https://images.contentstack.io/v3/assets/blt90bbfcce23680d08/bltb87e0bd5764c421e/64abd49b7b26dfaeede17525/batman.png" alt="I am BATMAN" caption="BATMAN" anchorLink="https://www.batman.com" class="embedded-asset" content-type-uid="sys_assets" type="asset" asset-alt="I am BATMAN" style="text-align: left; max-width: undefinedpx; width: auto" data-sys-asset-filelink="https://images.contentstack.io/v3/assets/blt90bbfcce23680d08/bltb87e0bd5764c421e/64abd49b7b26dfaeede17525/batman.png" data-sys-asset-uid="bltb87e0bd5764c421e" data-sys-asset-filename="batman.png" data-sys-asset-contenttype="image/png" data-sys-asset-caption="BATMAN" data-sys-asset-alt="I am BATMAN" data-sys-asset-link="https://www.batman.com" data-sys-asset-position="left" data-sys-asset-isnewtab="true" sys-style-type="display"/></a><figcaption style="text-align:center">BATMAN</figcaption></div></figure><figure style="margin: 0; text-align: center"><div style="display: inline-block"><a href="https://www.batman.com" target="_blank"><img src="https://images.contentstack.io/v3/assets/blt90bbfcce23680d08/bltb87e0bd5764c421e/64abd49b7b26dfaeede17525/batman.png" alt="I am BATMAN" caption="BATMAN" anchorLink="https://www.batman.com" class="embedded-asset" content-type-uid="sys_assets" type="asset" asset-alt="I am BATMAN" style="text-align: center; max-width: undefinedpx; width: auto" data-sys-asset-filelink="https://images.contentstack.io/v3/assets/blt90bbfcce23680d08/bltb87e0bd5764c421e/64abd49b7b26dfaeede17525/batman.png" data-sys-asset-uid="bltb87e0bd5764c421e" data-sys-asset-filename="batman.png" data-sys-asset-contenttype="image/png" data-sys-asset-caption="BATMAN" data-sys-asset-alt="I am BATMAN" data-sys-asset-link="https://www.batman.com" data-sys-asset-position="center" data-sys-asset-isnewtab="true" sys-style-type="display"/></a><figcaption style="text-align:center">BATMAN</figcaption></div></figure><figure style="margin: 0; text-align: right"><div style="display: inline-block"><a href="https://www.batman.com" target="_blank"><img src="https://images.contentstack.io/v3/assets/blt90bbfcce23680d08/bltb87e0bd5764c421e/64abd49b7b26dfaeede17525/batman.png" alt="I am BATMAN" caption="BATMAN" anchorLink="https://www.batman.com" class="embedded-asset" content-type-uid="sys_assets" type="asset" asset-alt="I am BATMAN" style="text-align: right; max-width: undefinedpx; width: auto" data-sys-asset-filelink="https://images.contentstack.io/v3/assets/blt90bbfcce23680d08/bltb87e0bd5764c421e/64abd49b7b26dfaeede17525/batman.png" data-sys-asset-uid="bltb87e0bd5764c421e" data-sys-asset-filename="batman.png" data-sys-asset-contenttype="image/png" data-sys-asset-caption="BATMAN" data-sys-asset-alt="I am BATMAN" data-sys-asset-link="https://www.batman.com" data-sys-asset-position="right" data-sys-asset-isnewtab="true" sys-style-type="display"/></a><figcaption style="text-align:center">BATMAN</figcaption></div></figure>`,
   },
   "inline-base": {
     value: getDoc([
@@ -647,7 +647,7 @@ export const imageAssetData = {
         ],
       },
     ]),
-    expectedHtml: `<div dir="ltr" style="overflow: hidden"><span><figure style="margin: 0; float: left"><img src="https://images.contentstack.io/v3/assets/blt90bbfcce23680d08/bltb87e0bd5764c421e/64abd49b7b26dfaeede17525/batman.png" inline="true" class="embedded-asset" content-type-uid="sys_assets" type="asset" dir="ltr" style="text-align: left;max-width: undefinedpx;float: left;text-align: left; max-width: undefinedpx; width: auto" data-sys-asset-filelink="https://images.contentstack.io/v3/assets/blt90bbfcce23680d08/bltb87e0bd5764c421e/64abd49b7b26dfaeede17525/batman.png" data-sys-asset-uid="bltb87e0bd5764c421e" data-sys-asset-filename="batman.png" data-sys-asset-contenttype="image/png" data-sys-asset-position="left" sys-style-type="display"/></figure>I am batman</span></div><div dir="ltr" style="overflow: hidden"><span><figure style="margin: 0; float: right"><img src="https://images.contentstack.io/v3/assets/blt90bbfcce23680d08/bltb87e0bd5764c421e/64abd49b7b26dfaeede17525/batman.png" inline="true" class="embedded-asset" content-type-uid="sys_assets" type="asset" style="text-align: right;max-width: undefinedpx;float: right;text-align: right; max-width: undefinedpx; width: auto" data-sys-asset-filelink="https://images.contentstack.io/v3/assets/blt90bbfcce23680d08/bltb87e0bd5764c421e/64abd49b7b26dfaeede17525/batman.png" data-sys-asset-uid="bltb87e0bd5764c421e" data-sys-asset-filename="batman.png" data-sys-asset-contenttype="image/png" data-sys-asset-position="right" sys-style-type="display"/></figure>I am batman</span></div>`,
+    expectedHtml: `<div dir="ltr" style="overflow: hidden"><span><figure style="margin: 0; float: left"><img src="https://images.contentstack.io/v3/assets/blt90bbfcce23680d08/bltb87e0bd5764c421e/64abd49b7b26dfaeede17525/batman.png" inline="true" class="embedded-asset" content-type-uid="sys_assets" type="asset" dir="ltr" style="text-align: left; max-width: undefinedpx; width: auto" data-sys-asset-filelink="https://images.contentstack.io/v3/assets/blt90bbfcce23680d08/bltb87e0bd5764c421e/64abd49b7b26dfaeede17525/batman.png" data-sys-asset-uid="bltb87e0bd5764c421e" data-sys-asset-filename="batman.png" data-sys-asset-contenttype="image/png" data-sys-asset-position="left" sys-style-type="display"/></figure>I am batman</span></div><div dir="ltr" style="overflow: hidden"><span><figure style="margin: 0; float: right"><img src="https://images.contentstack.io/v3/assets/blt90bbfcce23680d08/bltb87e0bd5764c421e/64abd49b7b26dfaeede17525/batman.png" inline="true" class="embedded-asset" content-type-uid="sys_assets" type="asset" style="text-align: right; max-width: undefinedpx; width: auto" data-sys-asset-filelink="https://images.contentstack.io/v3/assets/blt90bbfcce23680d08/bltb87e0bd5764c421e/64abd49b7b26dfaeede17525/batman.png" data-sys-asset-uid="bltb87e0bd5764c421e" data-sys-asset-filename="batman.png" data-sys-asset-contenttype="image/png" data-sys-asset-position="right" sys-style-type="display"/></figure>I am batman</span></div>`,
   },
   "inline-anchor": {
     value: getDoc([
@@ -873,7 +873,7 @@ export const imageAssetData = {
         ],
       },
     ]),
-    expectedHtml: `<div dir="ltr" style="overflow: hidden"><span><figure style="margin: 0; float: left"><div style="display: inline-block"><a href="https://www.batman.com" target="_blank"><img src="https://images.contentstack.io/v3/assets/blt90bbfcce23680d08/bltb87e0bd5764c421e/64abd49b7b26dfaeede17525/batman.png" alt="I am BATMAN" caption="BATMAN" anchorLink="https://www.batman.com" inline="true" class="embedded-asset" content-type-uid="sys_assets" type="asset" asset-alt="I am BATMAN" style="text-align: left;max-width: undefinedpx;float: left;text-align: left; max-width: undefinedpx; width: auto" data-sys-asset-filelink="https://images.contentstack.io/v3/assets/blt90bbfcce23680d08/bltb87e0bd5764c421e/64abd49b7b26dfaeede17525/batman.png" data-sys-asset-uid="bltb87e0bd5764c421e" data-sys-asset-filename="batman.png" data-sys-asset-contenttype="image/png" data-sys-asset-caption="BATMAN" data-sys-asset-alt="I am BATMAN" data-sys-asset-link="https://www.batman.com" data-sys-asset-position="left" data-sys-asset-isnewtab="true" sys-style-type="display"/></a><figcaption style="text-align:center">BATMAN</figcaption></div></figure>I am batman</span></div><div dir="ltr" style="overflow: hidden"><span><figure style="margin: 0; float: right"><div style="display: inline-block"><a href="https://www.batman.com" target="_blank"><img src="https://images.contentstack.io/v3/assets/blt90bbfcce23680d08/bltb87e0bd5764c421e/64abd49b7b26dfaeede17525/batman.png" alt="I am BATMAN" caption="BATMAN" anchorLink="https://www.batman.com" inline="true" class="embedded-asset" content-type-uid="sys_assets" type="asset" asset-alt="I am BATMAN" style="text-align: right;max-width: undefinedpx;float: right;text-align: right; max-width: undefinedpx; width: auto" data-sys-asset-filelink="https://images.contentstack.io/v3/assets/blt90bbfcce23680d08/bltb87e0bd5764c421e/64abd49b7b26dfaeede17525/batman.png" data-sys-asset-uid="bltb87e0bd5764c421e" data-sys-asset-filename="batman.png" data-sys-asset-contenttype="image/png" data-sys-asset-caption="BATMAN" data-sys-asset-alt="I am BATMAN" data-sys-asset-link="https://www.batman.com" data-sys-asset-position="right" data-sys-asset-isnewtab="true" sys-style-type="display"/></a><figcaption style="text-align:center">BATMAN</figcaption></div></figure>I am batman</span></div>`,
+    expectedHtml: `<div dir="ltr" style="overflow: hidden"><span><figure style="margin: 0; float: left"><div style="display: inline-block"><a href="https://www.batman.com" target="_blank"><img src="https://images.contentstack.io/v3/assets/blt90bbfcce23680d08/bltb87e0bd5764c421e/64abd49b7b26dfaeede17525/batman.png" alt="I am BATMAN" caption="BATMAN" anchorLink="https://www.batman.com" inline="true" class="embedded-asset" content-type-uid="sys_assets" type="asset" asset-alt="I am BATMAN" style="text-align: left; max-width: undefinedpx; width: auto" data-sys-asset-filelink="https://images.contentstack.io/v3/assets/blt90bbfcce23680d08/bltb87e0bd5764c421e/64abd49b7b26dfaeede17525/batman.png" data-sys-asset-uid="bltb87e0bd5764c421e" data-sys-asset-filename="batman.png" data-sys-asset-contenttype="image/png" data-sys-asset-caption="BATMAN" data-sys-asset-alt="I am BATMAN" data-sys-asset-link="https://www.batman.com" data-sys-asset-position="left" data-sys-asset-isnewtab="true" sys-style-type="display"/></a><figcaption style="text-align:center">BATMAN</figcaption></div></figure>I am batman</span></div><div dir="ltr" style="overflow: hidden"><span><figure style="margin: 0; float: right"><div style="display: inline-block"><a href="https://www.batman.com" target="_blank"><img src="https://images.contentstack.io/v3/assets/blt90bbfcce23680d08/bltb87e0bd5764c421e/64abd49b7b26dfaeede17525/batman.png" alt="I am BATMAN" caption="BATMAN" anchorLink="https://www.batman.com" inline="true" class="embedded-asset" content-type-uid="sys_assets" type="asset" asset-alt="I am BATMAN" style="text-align: right; max-width: undefinedpx; width: auto" data-sys-asset-filelink="https://images.contentstack.io/v3/assets/blt90bbfcce23680d08/bltb87e0bd5764c421e/64abd49b7b26dfaeede17525/batman.png" data-sys-asset-uid="bltb87e0bd5764c421e" data-sys-asset-filename="batman.png" data-sys-asset-contenttype="image/png" data-sys-asset-caption="BATMAN" data-sys-asset-alt="I am BATMAN" data-sys-asset-link="https://www.batman.com" data-sys-asset-position="right" data-sys-asset-isnewtab="true" sys-style-type="display"/></a><figcaption style="text-align:center">BATMAN</figcaption></div></figure>I am batman</span></div>`,
   },
 };