Text selection: Improved functionality of text selection by allowing multiple edit ranges to be highlighted. If you've used command+I multiple times to add multiple ranges to Edit, then they should all be shown highlighted in the editor, not just the most recent one.

Author: GauravVBhambhani

extensions/vscode/src/commands.ts

@@ -569,7 +569,7 @@ const getCommandsMap: (
       const range =
         args?.range ?? new vscode.Range(startFromCharZero, endAtCharLast);
 
-      editDecorationManager.setDecoration(editor, range);
+      editDecorationManager.setDecoration(editor, [range]);
 
       const rangeInFileWithContents = getRangeInFileWithContents(true, range);
 

extensions/vscode/src/quickEdit/EditDecorationManager.ts

@@ -2,6 +2,8 @@ import vscode from "vscode";
 class EditDecorationManager {
   private _lastEditor: vscode.TextEditor | undefined;
   private decorationType: vscode.TextEditorDecorationType;
+  private activeRanges: vscode.Range[] = []; // Store active ranges to be highlighted
+  private activeRangeSet: Set<string> = new Set(); // Store active ranges as strings to avoid duplicates
 
   constructor(context: vscode.ExtensionContext) {
     this.decorationType = vscode.window.createTextEditorDecorationType({
@@ -23,18 +25,40 @@ class EditDecorationManager {
     );
   }
 
-  setDecoration(editor: vscode.TextEditor, range: vscode.Range) {
-    if (this._lastEditor) {
-      this._lastEditor.setDecorations(this.decorationType, []);
+  // converting each range to a unique string for storing in set
+  private rangeToString(range: vscode.Range): string {
+    return `${range.start.line}:${range.start.character}-${range.end.line}:${range.end.character}`;
+  }
+
+  setDecoration(editor: vscode.TextEditor, ranges: vscode.Range[]): void {
+    if (this._lastEditor?.document !== editor.document) {
+      this.clear(); // Clear previous decorations if editor has changed
     }
-    editor.setDecorations(this.decorationType, [range]);
     this._lastEditor = editor;
+
+    // Filter out already highlighted ranges
+    const newRanges = ranges.filter(range => {
+      const rangeKey = this.rangeToString(range);
+      if (this.activeRangeSet.has(rangeKey)) {
+        return false; // already highlighted
+      }
+      this.activeRangeSet.add(rangeKey);
+      return true;
+    });
+
+    if (newRanges.length === 0) return; // No new ranges to highlight
+
+    // Update active ranges and apply decorations
+    this.activeRanges.push(...newRanges);
+    editor.setDecorations(this.decorationType, this.activeRanges);
     this.updateInEditMode(true);
   }
 
   clear() {
     if (this._lastEditor) {
       this._lastEditor.setDecorations(this.decorationType, []);
+      this.activeRanges = []; // Clear active ranges
+      this.activeRangeSet.clear(); // Clear active range set
       this._lastEditor = undefined;
       this.updateInEditMode(false);
     }