Skip to content
This repository has been archived by the owner on Nov 23, 2021. It is now read-only.

Mishandled errors inside the 'row success' event callback #10

Open
gnapse opened this issue Feb 25, 2014 · 0 comments
Open

Mishandled errors inside the 'row success' event callback #10

gnapse opened this issue Feb 25, 2014 · 0 comments
Labels

Comments

@gnapse
Copy link
Contributor

gnapse commented Feb 25, 2014

What should be the importer behavior when an exception occurs inside an on :row_success block?

The row was supposedly processed successfully, so exceptions on this event are not captured and sent to the on :row_error handler. Actually, if an exception occurs on the success handler, the importer process ends abnormally, and it shouldn't.

The same problem applies to most if not all of the other callback events, including on :row_processed and on :row_error. How should active_importer handle exceptions occurring inside these event callbacks?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

1 participant