Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamics type #137

Closed
jbcaillau opened this issue May 20, 2024 · 2 comments
Closed

Dynamics type #137

jbcaillau opened this issue May 20, 2024 · 2 comments
Assignees

Comments

@jbcaillau
Copy link
Member

jbcaillau commented May 20, 2024

@ocots just to be sure / for the record: do we agree that the motivation for the typing of Dynamics below, for instance allowing to call with time and / or variable arguments while the ocp is {Autonomous, Fixed}, is intended to enable a uniform call (e.g. in CTDirect.jl) with the most general signature, a.k.a. (t,x,u,v)?

For the sake of sanity, I would otherwise strongly advocate forbidding this (seemingly incoherent) use (i.e. using a time argument with an Autonomous ocp, etc.) On the contrary, I agree that it is convenient for developers to have access to uniform calls. changed my mind on this, not important

function (F::VectorField{Autonomous, Fixed})(x::State)::ctVector

IMG_3139

@jbcaillau
Copy link
Member Author

jbcaillau commented May 21, 2024

@ocots below the getters that correspond to setters on an ocp (instead of using fields):

variable
time
state
control
dynamics
constraint
objective

Double check with usage in CTDirect and ocp fields.

Also: allows to use an abstract ocp.

@jbcaillau
Copy link
Member Author

FYI @PierreMartinon @joseph-gergaud : might be some similar things (some already implemented) to add in the interface (= exported setters / getters & more) of CTDirect.jl.

@ocots ocots mentioned this issue Jun 15, 2024
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants