Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dev] Aqua tests #265

Closed
ocots opened this issue Sep 2, 2024 · 4 comments · Fixed by #277
Closed

[Dev] Aqua tests #265

ocots opened this issue Sep 2, 2024 · 4 comments · Fixed by #277
Assignees
Labels
internal dev Modification to the code is requested and should not affect user experiment

Comments

@ocots
Copy link
Member

ocots commented Sep 2, 2024

@PierreMartinon I found how to use Aqua without being warn for dependencies. See https://github.com/control-toolbox/CTBase.jl/blob/main/test/test_aqua.jl.

When Aqua is used, you can add a badge. See https://github.com/control-toolbox/CTBase.jl/blob/a9744ff7cfaed4126c2bdbddce55b8adbf344010/README.md?plain=1#L38.

@ocots ocots added the internal dev Modification to the code is requested and should not affect user experiment label Sep 2, 2024
@amontoison
Copy link
Contributor

amontoison commented Sep 2, 2024

@ocots I created a workflow to use Aqua.jl without adding it as a dependency:

I preferred this approach for Krylov.jl and the other packages in JSO because it doesn't pollute Project.toml.
It could be relevant for your organization.

@ocots
Copy link
Member Author

ocots commented Sep 3, 2024

@amontoison Maybe we could add something like:

PKG_SRC_PATH=`pwd`
PKG_SRC_NAME=`basename -s ".jl" $PKG_SRC_PATH`

to get the name of the package instead of hard-coding Krylov.

@amontoison
Copy link
Contributor

Good idea @ocots! I will try it.
I did the script 2 years ago and was too lazy to make it generic.

@amontoison
Copy link
Contributor

-> JuliaSmoothOptimizers/Krylov.jl#873

@ocots ocots linked a pull request Sep 6, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal dev Modification to the code is requested and should not affect user experiment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants