Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update DOCP #323

Open
PierreMartinon opened this issue Nov 18, 2024 · 0 comments
Open

Update DOCP #323

PierreMartinon opened this issue Nov 18, 2024 · 0 comments
Assignees

Comments

@PierreMartinon
Copy link
Member

PierreMartinon commented Nov 18, 2024

Many (too many !) fields were added in the DOCP that complete / mirror the ones in OCP, partly for convenience and also to fix some types. Once OCP is redone, DOCP should be updated, with 2 possible directions:
a) keep a copy of the OCP in DOCP, and remove all the duplicate fields
b) remove the OCP and make DOCP self-sufficient, with a better constructor taking the ocp and the few discretization parameters, instead of all the individual fields

Having the OCP inside is nice since we have all relevant information available, in particular when rebuilding the OCP solution from the discrete one. If we manage to have good types in the OCP I think it would be the easier path. One potential drawback is that it makes DOCP less generic since it ties it to the OCP, however it is not completely clear how we would use the DOCP outside of OptimalControl / CTBase anyway.

Notes:

  • DOCP is currently non-mutable, which supposedly helps with code optimization
  • fields could also be reorganized into sub-structs for a more compact constructor call. For instance we already have a struct inside DOCP for the discretization.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants