Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow to use a date/time string in default expiration time configuration #19

Merged
merged 1 commit into from
Oct 18, 2023
Merged

feat: allow to use a date/time string in default expiration time configuration #19

merged 1 commit into from
Oct 18, 2023

Conversation

pauljosephkrogulec
Copy link
Contributor

@pauljosephkrogulec pauljosephkrogulec commented Apr 5, 2023

Q A
Bug fix? no
New feature? yes
Deprecations? no
Tickets Fix #12
License MIT

Allow to use a date/time string in default expiration time configuration.

Waiting for the merge of spatie/url-signer#45.

@coveralls
Copy link

coveralls commented Apr 5, 2023

Pull Request Test Coverage Report for Build 4618772481

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 2 of 2 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 4427821652: 0.0%
Covered Lines: 51
Relevant Lines: 51

💛 - Coveralls

@alanpoulain alanpoulain merged commit f4bc112 into coopTilleuls:main Oct 18, 2023
@alanpoulain alanpoulain changed the title feat: enable DateTime in sign constructor feat: allow to use a date/time string in default expiration time configuration Oct 18, 2023
@alanpoulain
Copy link
Contributor

Thank you 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Default expiration format in other than days
3 participants