Skip to content

Commit

Permalink
Merge pull request #181 from nikki-quant/fix/role-name-override
Browse files Browse the repository at this point in the history
fix: add default value for clusterRole name override
  • Loading branch information
hagaibarel authored Oct 28, 2024
2 parents 7b685ba + 68c2d31 commit 1f417ad
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 3 deletions.
6 changes: 3 additions & 3 deletions charts/coredns/Chart.yaml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
apiVersion: v2
name: coredns
version: 1.36.0
version: 1.36.1
appVersion: 1.11.3
home: https://coredns.io
icon: https://coredns.io/images/CoreDNS_Colour_Horizontal.png
Expand All @@ -19,5 +19,5 @@ maintainers:
type: application
annotations:
artifacthub.io/changes: |
- kind: changed
description: Add environment variables on container specs
- kind: fix
description: Add default values to chart to fix cluster role name templating issue
5 changes: 5 additions & 0 deletions charts/coredns/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,11 @@ rbac:
# If not set and create is true, a name is generated using the fullname template
# name:

clusterRole:
# By default a name is generated using the fullname template.
# Override here if desired:
nameOverride: ""

# isClusterService specifies whether chart should be deployed as cluster-service or normal k8s app.
isClusterService: true

Expand Down

0 comments on commit 1f417ad

Please sign in to comment.