From 2cd36c969b335d79512e96377396ee4e2e885dec Mon Sep 17 00:00:00 2001 From: Dinar Valeev Date: Tue, 6 Apr 2021 15:25:38 +0200 Subject: [PATCH 1/3] Allow to skip ConfigMap creation There are cases where zones are different but plugins are. In order to avoid duplication of whole zone block configuration, allow to disable config map creation and let it to be managable externally, where it is possible to keep plugins configuration same, but change zone definition only. Signed-off-by: Dinar Valeev --- charts/coredns/Chart.yaml | 2 +- charts/coredns/templates/configmap.yaml | 4 +++- charts/coredns/values.yaml | 1 + 3 files changed, 5 insertions(+), 2 deletions(-) diff --git a/charts/coredns/Chart.yaml b/charts/coredns/Chart.yaml index 13dca33..ebd9637 100644 --- a/charts/coredns/Chart.yaml +++ b/charts/coredns/Chart.yaml @@ -1,6 +1,6 @@ apiVersion: v2 name: coredns -version: 1.16.3 +version: 1.16.4 appVersion: 1.8.4 home: https://coredns.io icon: https://coredns.io/images/CoreDNS_Colour_Horizontal.png diff --git a/charts/coredns/templates/configmap.yaml b/charts/coredns/templates/configmap.yaml index ebbea9b..4aa9498 100644 --- a/charts/coredns/templates/configmap.yaml +++ b/charts/coredns/templates/configmap.yaml @@ -1,4 +1,5 @@ -{{- if .Values.deployment.enabled }} +{{- if .Values.deployment.enabled }} +{{- if not .Values.deployment.skipConfig }} --- apiVersion: v1 kind: ConfigMap @@ -34,3 +35,4 @@ data: {{ .filename }}: {{ toYaml .contents | indent 4 }} {{- end }} {{- end }} +{{- end }} diff --git a/charts/coredns/values.yaml b/charts/coredns/values.yaml index c952736..c690339 100644 --- a/charts/coredns/values.yaml +++ b/charts/coredns/values.yaml @@ -297,5 +297,6 @@ autoscaler: successThreshold: 1 deployment: + skipConfig: false enabled: true name: "" From 48a1349f76aa8c54170c86aae354795a87e712f6 Mon Sep 17 00:00:00 2001 From: Jack Lindamood Date: Sun, 19 May 2024 11:47:18 -0700 Subject: [PATCH 2/3] fix: fix spaces Signed-off-by: Jack Lindamood --- charts/coredns/Chart.yaml | 2 ++ charts/coredns/templates/configmap.yaml | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/charts/coredns/Chart.yaml b/charts/coredns/Chart.yaml index 9dd9aaf..ba96098 100644 --- a/charts/coredns/Chart.yaml +++ b/charts/coredns/Chart.yaml @@ -23,3 +23,5 @@ annotations: description: Ignore duplicate strings in the fullname helper template - kind: removed description: Removed deprecated "engine: gotpl" from the Chart.yaml + - kind: added + description: Ability to skip configmap management diff --git a/charts/coredns/templates/configmap.yaml b/charts/coredns/templates/configmap.yaml index 2154b76..e37858c 100644 --- a/charts/coredns/templates/configmap.yaml +++ b/charts/coredns/templates/configmap.yaml @@ -1,4 +1,4 @@ -{{- if .Values.deployment.enabled }} +{{- if .Values.deployment.enabled }} {{- if not .Values.deployment.skipConfig }} --- apiVersion: v1 From 992e3a192d0878febb43d7ee9cdd8c847f79d445 Mon Sep 17 00:00:00 2001 From: Jack Lindamood Date: Tue, 28 May 2024 08:06:44 -0700 Subject: [PATCH 3/3] fix: only one change Signed-off-by: Jack Lindamood --- charts/coredns/Chart.yaml | 4 ---- 1 file changed, 4 deletions(-) diff --git a/charts/coredns/Chart.yaml b/charts/coredns/Chart.yaml index ba96098..be84a05 100644 --- a/charts/coredns/Chart.yaml +++ b/charts/coredns/Chart.yaml @@ -19,9 +19,5 @@ maintainers: type: application annotations: artifacthub.io/changes: | - - kind: changed - description: Ignore duplicate strings in the fullname helper template - - kind: removed - description: Removed deprecated "engine: gotpl" from the Chart.yaml - kind: added description: Ability to skip configmap management