Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bare-metal: add section on PXE rootfs migration #112

Merged
merged 4 commits into from
Jul 27, 2020
Merged

bare-metal: add section on PXE rootfs migration #112

merged 4 commits into from
Jul 27, 2020

Conversation

bgilbert
Copy link
Contributor

@bgilbert bgilbert commented Jul 27, 2020

Don't update the PXE instructions yet, since we're not yet producing rootfs images.

Also simplify PXE kargs.

For coreos/fedora-coreos-tracker#390.

bgilbert added 4 commits July 27, 2020 07:06
Many users won't need them.  Let's keep the default argument list as
simple as possible.
They're no longer required on current OS versions.
Don't update the PXE instructions yet, since we're not yet producing
rootfs images.
Copy link
Member

@dustymabe dustymabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jlebon
Copy link
Member

jlebon commented Jul 27, 2020

Shouldn't the last commit also change the example PXE configs to use either ,fedora-coreos-32.20200715.3.0-live-rootfs.x86_64.img or coreos.live.rootfs_url=?

@bgilbert
Copy link
Contributor Author

@jlebon Not for another two weeks.

Copy link
Member

@jlebon jlebon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jlebon Not for another two weeks.

Ahh sorry, misunderstood your first line as "don't merge until we produce live-rootfs artifacts".

@bgilbert bgilbert merged commit 9697a0a into coreos:master Jul 27, 2020
@bgilbert bgilbert deleted the pxe branch July 27, 2020 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants