Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider updating countme logic to match dnf countme changes (using /etc/machine-id as system epoch) #5020

Open
travier opened this issue Jul 18, 2024 · 0 comments

Comments

@travier
Copy link
Member

travier commented Jul 18, 2024

Describe the bug

The implementation of the count me logic in dnf was "per-repo" and thus was resetting the system time on every major Fedora update: rpm-software-management/libdnf#1611

The implementation in rpm-ostree does not suffer from this issue as it stores this information in a file independent of any repo: https://github.com/coreos/rpm-ostree/blob/main/rust/src/countme/cookie.rs#L11

We may or may not want to change our implementation to match the new one in dnf, which uses the /etc/machine-id file modification timestamp as the epoch for the system.

See: rpm-software-management/libdnf#1662

We can also keep things as is as this is not a problem for us right now and the current implementation works well enough.

Reproduction steps

N/A

Expected behavior

We use the same logic as dnf for our count me logic.

Actual behavior

We use a similar but not exactly the same logic.

System details

N/A

Additional information

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant