Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: matomo tracking #151

Merged
merged 1 commit into from
Nov 19, 2024
Merged

fix: matomo tracking #151

merged 1 commit into from
Nov 19, 2024

Conversation

fzipi
Copy link
Member

@fzipi fzipi commented Nov 19, 2024

what

  • split (duplicated) javascript tracking and image tracking

why

  • fixes matomo breaking the content div

Fixes coreruleset/website#305

Signed-off-by: Felipe Zipitria <[email protected]>
@fzipi fzipi requested a review from theseion November 19, 2024 12:14
Copy link
Contributor

@theseion theseion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know why it works, but it does.

@theseion
Copy link
Contributor

Ok, now I do understand. The image has a width which makes the leftmost div much wider than it should be. Now the image is in the content div.

@theseion theseion merged commit f9e8881 into main Nov 19, 2024
1 check passed
@theseion theseion deleted the fix-matomo branch November 19, 2024 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Styling is very broken
2 participants