You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Issue:
On a fresh machine (where node-windows has never run before), if I initiate two or more installs (of different services) simultaneously, we see an intermittent issue where:
) does not find the daemon folder (because nod-windows has not been run yet and daemon folder is actually not there).
Since fs.exists is async (also deprecated), all calls in step 1 will try to create the daemon folder.
This leads to a collision where all the installs after the first one (whoever gets to create daemon folder) will fail with an error saying daemon folder already exists.
How To Reproduce:
Give multiple install commands simultaneously.
Expected Behavior:
daemon folder should be created without errors and services should get installed.
Desktop:
OS: Windows 11
Probable Fix:
We should be using the fs.existsSync function instead of fs.exists at
Issue:
On a fresh machine (where node-windows has never run before), if I initiate two or more installs (of different services) simultaneously, we see an intermittent issue where:
node-windows/lib/daemon.js
Line 540 in 27779d9
How To Reproduce:
Give multiple install commands simultaneously.
Expected Behavior:
daemon folder should be created without errors and services should get installed.
Desktop:
Probable Fix:
We should be using the fs.existsSync function instead of fs.exists at
node-windows/lib/daemon.js
Line 540 in 27779d9
@coreybutler if you want, I can raise a PR with this fix
The text was updated successfully, but these errors were encountered: