Add support for custom hashers #51
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a random state `S` as a generic type, and uses the standard RandomState to maintain backward compatibility.
|
Thanks for the contribution! It's likely to be a few days before I can properly review this--life is hectic right now--but I have seen it, and it's on my task queue. |
|
I'm installing off my fork for the time being so no rush on my end :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempts to close #32. Still needs documentation etc, but figured I'd get the initial PR up for code review.
I'm fairly new to rust so feel free to be brutal here! It's likely that I'm missing something obvious here.
I was looking into whether it would be plausible to also be generic over the map type (say, to allow
BTreeMapinstead ofHashMapwhich might be handy when it comes to things likek_most_common, but was struggling to see how to make it be generic over both.