Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use eigen-vectors when possible #11

Open
ndehio opened this issue Jan 9, 2017 · 2 comments
Open

Use eigen-vectors when possible #11

ndehio opened this issue Jan 9, 2017 · 2 comments
Assignees
Labels

Comments

@ndehio
Copy link
Collaborator

ndehio commented Jan 9, 2017

The following types are based on eigen-matrices, however we should use eigen-vectors instead:

  • dynamics/Torques
  • dynamics/Forces
  • dynamics/Wrench
  • geometry/Rotation
  • geometry/Translation
@Pouya-moh
Copy link
Collaborator

While this could help with readability, conceptually it is exactly the same:

typedef Matrix< float, 3, 1 >        Eigen::Vector3f
typedef Matrix< float, Dynamic, 1 >  Eigen::VectorXf

To me it is a bit of a not-so-necessary-refactoring-effort.

@xwavex
Copy link
Collaborator

xwavex commented Apr 3, 2017 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants