Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Umd distribution no longer being included in the release packages #1594

Open
plt-joey opened this issue Nov 15, 2024 · 1 comment
Open

Comments

@plt-joey
Copy link
Contributor

Describe the Bug

Every version of the library since 2.0.0-beta.27 has been missing dist/umd from the release packages, despite there being no documented removal of it (that I could find) and the 2.0.0 migration guide stating that it should still exist.

image
image

umd

Steps to Reproduce

  1. navigate to https://www.npmjs.com/package/@cornerstonejs/core
  2. click the code tab
  3. navigate to /dist, note the lack of umd
  4. click the versions tab
  5. go to any version before 2.0.0-beta.27
  6. check /dist again
  7. go to version 2.0.0-beta.27
  8. check /dist again

The current behavior

The umd distribution is missing from the library, contradicting the documentation.

The expected behavior

Either:

  1. The umd distribution is re-added to the published package
  2. The documentation is updated to reflect that it has been removed

OS

Windows 10

Node version

v18.20.4

Browser

Chrome 130.0.6723.117

Copy link
Member

sedghi commented Nov 15, 2024

Yes that is intentional, use ESM, it works, I will update the doc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants