Skip to content
This repository has been archived by the owner on Dec 29, 2024. It is now read-only.

2024.6 Bitwarden uses camelCase keys instead of PascalCase #29

Closed
wants to merge 15 commits into from

Conversation

OdyX
Copy link
Contributor

@OdyX OdyX commented Jul 17, 2024

This fixes client access to a 1.31 Vaultwarden instance, see:

@OdyX OdyX force-pushed the 2024-07-API-lowercase branch 3 times, most recently from 946d974 to 297dce2 Compare July 17, 2024 08:39
@OdyX OdyX force-pushed the 2024-07-API-lowercase branch from 297dce2 to 1282008 Compare July 17, 2024 08:50
src/bitwardentools/client.py Outdated Show resolved Hide resolved
@commonism
Copy link
Contributor

Required for Vaultwarden 1.31 released 08.07.2024

https://github.com/dani-garcia/vaultwarden/releases/tag/1.31.0

Change API and structs to camelCase by @dani-garcia in dani-garcia/vaultwarden#4386

@commonism
Copy link
Contributor

@kiorky - this needs your attention, all tooling using bitwarden tools is broken by the API changes and require these updates.

@kiorky
Copy link
Contributor

kiorky commented Jul 23, 2024

As it is , i do not know what to do because this PR seems highly backward incompatible, and do not know if i have currently enough bandwidth to do more than a review ...

If someone can contribute some glue to try/fallback on new (non camelcase) vs old structure, i will be happy to merge it.

@commonism
Copy link
Contributor

Would you accept a patch which makes use of pydantic to process/validate the json?
pydantic is quite a dependency but … besides best in class validation it adds comfort.

e.g. - https://docs.pydantic.dev/latest/concepts/alias/

@kiorky
Copy link
Contributor

kiorky commented Dec 12, 2024

Hello, i want to thanks you very much as it largely inspired the latest release with my own fix !

@kiorky kiorky closed this Dec 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants