New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bad practices #1

Open

max-allan-surevine opened this issue Aug 4, 2022 · 0 comments

max-allan-surevine commented Aug 4, 2022

First, in your Dockerfile, do not include your GitHub PAT. Even if it is base64 encoded.

Second, do not try to process the JSON you download from GitHub with grep. It would be a lot clearer if you used jq and a lot less likely to break.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment