-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The patch for the zlib is not needed after 1.2.13 version #109
base: develop
Are you sure you want to change the base?
Conversation
@@ -65,25 +65,10 @@ task copySource(type: Exec) { | |||
"${project.rootDir}/", buildRoot | |||
} | |||
|
|||
/** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would like to leave the code to apply patches in, we do use this functionality in other versions and make need it again here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we actually use it? I think we do not do it and instead always push to the repo, the one exception is JFX.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure I like the solution when the source code has one version of the file, the build via make will use that file, but the build via gradle will use some other customized files.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We use it in 11 https://github.com/corretto/corretto-11/tree/develop/installers/linux/alpine/tar/patches
I think there was a patch that didn't play nice on other platforms and there wasn't a nice way to have it be MUSL_AARCH64 only, but I could be wrong.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
O_o
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So if that patch will fail we even will not know that...
I'll postpone this change and take a look at that patch.
Custom patches for Zlib are removed. All that changes are present in the bundle zlib library.