Extended Source Response Generation

[hiyoneda]

I made schematics about how the classes related to the response matrix are connected through their class methods.
For the point source response, FullDetectorResponse is tied with PointSourceResponse by FullDetectorResponse.get_point_source_response, and the expected counts are calculated through PointSourceResponse.get_expectation.

When I implemented ExtendedSourceResponse, I was focusing on the expected count calculation part, i.e., ExtendedSourceResponse.get_expection and ExtendedSourceResponse.get_expectation_from_astromodel. So, currently, there is no function to generate ExtendedSourceResponse from FullDetectorResponse.

We can discuss where we should add such a method in cosipy, but I think it is natural to add a new method in FullDetectorResponse.
It can be based on some notebooks on which we generated the pre-computed response file for DC2 (while I don't know where the latest one is (and who has it)).

Regarding this, I have two questions.

• SpacecraftFile also has a method to generate PointSourceResponse; SpacecraftFile.get_psr_rsp. Do you think we should keep it or remove it in the future?
• Do you think that we should rename ExtendedSourceResponse.get_expection to something like ExtendedSourceResponse.get_expection_from_hist and ExtendedSourceResponse.get_expectation_from_astromodel to ExtendedSourceResponse.get_expection? It is because the input of PointSourceResponse.get_expectation is astromodel function, but that of ``ExtendedSourceResponse.get_expection` is the model cube histogram. The naming is the same, but the input parameter is different, which may be confusing?