Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using the [APPROVALS] tag does not show the "By" name #170

Open
mosely1 opened this issue Mar 20, 2023 · 1 comment
Open

Using the [APPROVALS] tag does not show the "By" name #170

mosely1 opened this issue Mar 20, 2023 · 1 comment

Comments

@mosely1
Copy link

mosely1 commented Mar 20, 2023

The [APPROVALS] tag gives a table of pages that need approval. The second column titled "Previous Approvals" says "By on YYYY-MM-DD hh:ss." I assume the intention is for there to be a name of a user after the word "By" but no such name appears. Is this a bug or is it something wrong with my configuration?

Similarly, the third column titled "Updated" only gives a date. It would be great if that column also gave a "By [name] on" where that was the name of the user who last made an edit to the page that needs approval.

Thanks!

@mosely1 mosely1 changed the title Using the [APPROVALS] tag not show the "By" name Using the [APPROVALS] tag does not show the "By" name Mar 20, 2023
@delahondes
Copy link

delahondes commented May 23, 2024

I've managed to do that by changing one line in the ./syntax.php file, line 106, change this:

$approved = sprintf($this->getLang('apr_p_approved'),
                    $page[1][$last][1],
                    wl($page[0], 'rev=' . $last),
                    dformat($last));

to this:

$approved = sprintf($this->getLang('apr_p_approved'),
                    implode(', ',array_keys($page[1][$last])),
                    wl($page[0], 'rev=' . $last),
                    dformat($last));

I'll try to propose a patch.

delahondes added a commit to delahondes/dokuwiki-plugin-publish that referenced this issue May 23, 2024
Correctly display name of previous approver (issue 170, cosmocode#170)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants