Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix some typos in comment #712

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore: fix some typos in comment #712

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/ast/scripts/test-ast.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// This file is a demonstation of how ast package works. In order to try it yourself you need:
// This file is a demonstration of how ast package works. In order to try it yourself you need:
// 1. Create a 'fixture.tx' file in the same directory as this file and write any TypeScript to it.
// 2. cd into `packages/ast`.
// 3. Run `yarn test:ast`.
Expand Down
8 changes: 4 additions & 4 deletions packages/ast/src/clients/rpc/class/grpc-web/grpc-web.msg.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,10 +185,10 @@ const rpcClassMethod = (
t.objectProperty(
t.identifier('pagination'),
paginationDefaultFromPartial ? t.callExpression(
t.memberExpression(t.identifier("PageRequest"), t.identifier("fromPartial")),
[t.objectExpression([])]
t.memberExpression(t.identifier("PageRequest"), t.identifier("fromPartial")),
[t.objectExpression([])]
) :
t.identifier('undefined'),
t.identifier('undefined'),
false,
false
)
Expand Down Expand Up @@ -349,7 +349,7 @@ export const getMethodDesc = (context: GenericParseContext, service: ProtoServic

const methodsDesc = []

//check if service name is 'service' if it is then ommit it because proto method doesn't contain service prefix in it methods
//check if service name is 'service' if it is then omit it because proto method doesn't contain service prefix in it methods
let service_name = service.name
if (service_name == 'Service') {
service_name = ''
Expand Down
2 changes: 1 addition & 1 deletion packages/parser/src/lookup.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,7 +172,7 @@ export const protoScopeImportLookup = (
const root = getRoot(ref);

// TODO pass in the imports and this ref
// e.g. only include packges of those files !!!!!
// e.g. only include packages of those files !!!!!
// this is currently looking at ALL protos
const parsed = store.parseScope(name);
if (!parsed) {
Expand Down