chore: deprecate v0.46 and v0.50 changelog #18119
Conversation
|
happy chore |
julienrbrt
changed the title
WalkthroughThe provided walkthrough and changes are comprehensive and well-structured. The poem adds a creative touch to the summary. If you have any specific questions or need further assistance, feel free to ask! TipsChat with CodeRabbit Bot (
|
github-actions
bot
added
C:x/evidence
C:x/upgrade
C:x/feegrant
C:x/nft
C:Confix
julienrbrt
changed the title
| @@ -240,3 +240,7 @@ Those modules can be considered as part of the Cosmos SDK, but features and impr | |||
| ### Modules that do not depend on the Cosmos SDK | |||
|
|
|||
| Modules that do not depend on the Cosmos SDK can be released at any time from the `main` branch of the Cosmos SDK repository. | |||
|
|
|||
| #### Exception to the rule | |||
julienrbrt
changed the title
github-prbot
requested review from
a team,
kocubinski and
facundomedica
and removed request for
a team
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review Status
Actionable comments generated: 1
Configuration used: CodeRabbit UI
Files selected for processing (12)
- .github/workflows/release.yml (1 hunks)
- CHANGELOG.md (12 hunks)
- README.md (1 hunks)
- RELEASE_PROCESS.md (2 hunks)
- client/v2/CHANGELOG.md (1 hunks)
- proto/README.md (1 hunks)
- tools/confix/CHANGELOG.md (1 hunks)
- x/circuit/CHANGELOG.md (1 hunks)
- x/evidence/CHANGELOG.md (2 hunks)
- x/feegrant/CHANGELOG.md (1 hunks)
- x/nft/CHANGELOG.md (1 hunks)
- x/upgrade/CHANGELOG.md (2 hunks)
Files skipped from review due to trivial changes (4)
- README.md
- proto/README.md
- x/circuit/CHANGELOG.md
- x/nft/CHANGELOG.md
Additional comments: 21
client/v2/CHANGELOG.md (1)
- 36-48: The changelog is well maintained and follows the recommended format. The breaking changes are clearly mentioned with the relevant issue links. Ensure that the version updates and the API breaking changes are communicated to all stakeholders.
x/feegrant/CHANGELOG.md (1)
- 27-43: Ensure that all calls to the functions mentioned in the changelog throughout the codebase have been updated to match the new signatures. Also, verify that the changes in the
NewKeeperfunction and the removal of global bech32 usage in the keeper do not break any existing functionality.tools/confix/CHANGELOG.md (1)
- 31-38: The changelog is well-structured and follows the recommended format. It provides clear information about the changes introduced in version v0.1.0 of the cosmos-sdk. Ensure that the links to the pull requests are correct and lead to the appropriate changes.
x/upgrade/CHANGELOG.md (2)
25-31: The change log entry for the state machine breaking change is clear and provides a link to the relevant issue for more context. Ensure that the issue link is correct and that it provides sufficient information for users to understand the change.
50-53: The bug fix entry is clear and provides a link to the relevant issue and ADR for more context. Ensure that the issue link and ADR link are correct and that they provide sufficient information for users to understand the change.
.github/workflows/release.yml (1)
- 1-51: The changes to the GitHub Actions workflow file look good. The workflow is set to trigger on tag push, which is a common practice for release workflows. The permissions are set correctly, allowing the workflow to read the repository contents and write for creating a release. The Go version is set to "1.21" and the
check-latestoption is enabled, ensuring the latest Go version is used. The new jobrelease-successis added to notify Slack on successful release, which is a good practice for visibility and tracking. The Slack notification settings are configured correctly.x/evidence/CHANGELOG.md (1)
- 26-32: The new version v0.1.0 is added with a link to the release on GitHub. The
x/evidencemodule is now a standalone module with its own go.mod file. Ensure that the link to the release is correct and the module extraction doesn't break any dependencies.RELEASE_PROCESS.md (2)
- 81-88: The supported major release series for the SDK have been updated. Ensure that the new versions are correctly reflected throughout the documentation and any related code.
- * **0.47** is the previous major release and is supported until the release of **0.51.0**. A fairly strict **bugfix-only** rule applies to pull requests that are requested to be included into a not latest stable point-release. - * **0.50** is the last major release and is supported until the release of **0.52.0**. + * **0.50** is the previous major release and is supported until the release of **0.53.0**. A fairly strict **bugfix-only** rule applies to pull requests that are requested to be included into a not latest stable point-release. + * **0.52** is the last major release and is supported until the release of **0.54.0**.
- 244-246: An exception has been added for the release of Store v1 from the
release/v0.50.xbranch. Ensure that this exception is properly handled in the release process.+ * Store v1 is released from `release/v0.50.x` branch.CHANGELOG.md (12)
48-49: The addition of base64 encoding for public keys can have implications for systems that interact with this data. Ensure that all systems that use this data can handle base64 encoded keys.
50-50: The introduction of a new message type,
MsgBurn, to burn coins can have significant implications for the token economy of the application. Ensure that this change is well-documented and communicated to users.56-57: The changes to the
x/govmodule, including limiting the accepted deposit coins for a proposal to the minimum proposal deposit denoms and improving<appd> q gov proposerby querying directly a proposal instead of tx events, can have significant implications for governance on the platform. Ensure that these changes are well-documented and communicated to users.Hunk 1:
68-74: The bug fixes in this hunk, including fixing a data race inside BaseApp.getContext, consistently setting viper prefix in client and server, and fixing problems with executing command
make test-sim-custom-genesis-fastfor simulation test, improve the stability and reliability of the application. These changes should be communicated to users to increase their confidence in the application.77-80: The API breaking changes in this hunk, including changes to
x/genutil,x/gov/testutil,x/staking/testutil, andx/bank/testutil, can have significant implications for developers building on top of this application. Ensure that these changes are well-documented and communicated to developers.Hunk 2:
193-197: The state machine breaking changes in this hunk, including migrating community pool funds from x/distribution to x/protocolpool and replacing
HistoricalInfowithHistoricalRecordinx/staking, can have significant implications for the state of the application. Ensure that these changes are well-documented and communicated to users.200-201: The client breaking change in this hunk, deprecating
CommunityPoolandFundCommunityPoolrpc methods and advising to use x/protocolpool module's rpc methods instead, can have significant implications for developers building on top of this application. Ensure that this change is well-documented and communicated to developers.Hunk 3:
- 239-240: The addition of a Textual SignModeHandler and the ability to query blocks by events with queries directly passed to Tendermint can have significant implications for developers building on top of this application. Ensure that these changes are well-documented and communicated to developers.
Hunk 4:
- 264-265: The improvements in this hunk, including improving
getSDKVersion()to handle module replacements and removingGetTxCmd() *cobra.CommandandGetQueryCmd() *cobra.Commandfrommodule.AppModuleBasicinterface, can have significant implications for developers building on top of this application. Ensure that these changes are well-documented and communicated to developers.Hunk 5:
- 312-313: The state machine breaking changes in this hunk, including adding a denom check to reject denoms outside of those listed in
MinDepositand rejecting a group and gov proposal if the proposal metadata title and summary do not match the proposal title and summary, can have significant implications for the state of the application. Ensure that these changes are well-documented and communicated to users.Hunk 6:
- 383-384: The API breaking changes in this hunk, including removing gRPC query methods from gov keeper and removing
GetSignBytesimplementations on messages and global legacy amino codec definitions from all modules, can have significant implications for developers building on top of this application. Ensure that these changes are well-documented and communicated to developers.Hunk 7:
- 476-477: The client breaking changes in this hunk, including removing telemetry for counting votes and proposals and adding
msg_indexto all event attributes to associate events and messages, can have significant implications for developers building on top of this application. Ensure that these changes are well-documented and communicated to developers.
There was a problem hiding this comment.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files selected for processing (5)
- tools/confix/CHANGELOG.md (1 hunks)
- x/evidence/CHANGELOG.md (2 hunks)
- x/feegrant/CHANGELOG.md (1 hunks)
- x/nft/CHANGELOG.md (1 hunks)
- x/upgrade/CHANGELOG.md (2 hunks)
Files skipped from review due to trivial changes (2)
- tools/confix/CHANGELOG.md
- x/nft/CHANGELOG.md
Additional comments: 6
x/feegrant/CHANGELOG.md (1)
- 27-43: The changelog is well-documented and provides clear information about the changes in the new version. Ensure that all the changes mentioned in the changelog are reflected in the codebase and that the API breaking changes are handled properly in the dependent code.
x/evidence/CHANGELOG.md (2)
25-32: The extraction of the
x/evidencemodule to have a separate go.mod file is a significant change. This allows it to be a standalone module, which could affect how it's imported and used in other parts of the codebase. Ensure that all references to this module have been updated accordingly.38-40: The changes to the evidence constructor and the removal of several keeper functions are breaking changes. As previously mentioned, these changes should be communicated to all developers using this module. Also, ensure that the removal of these functions doesn't break any existing functionality.
x/upgrade/CHANGELOG.md (3)
26-30: The change in the state machine is a significant one and could potentially impact other parts of the system. Ensure that all dependencies and modules that interact with the app version are updated to fetch it from the
ParamStoreof baseapp.32-36: The switch from using gov v1beta1 to gov v1 in upgrade CLIs is a breaking change. Make sure that all the clients using the upgrade CLIs are aware of this change and have updated their code accordingly.
50-53: The replacement of
BeginBlockbyPreBlockis a bug fix. Ensure that this change doesn't introduce any new bugs or issues in the system.
There was a problem hiding this comment.
Review Status
Actionable comments generated: 1
Configuration used: CodeRabbit UI
Files selected for processing (1)
- .github/workflows/lint.yml (1 hunks)
Additional comments: 2
.github/workflows/lint.yml (2)
20-22: The
go-versionis set to "1.21". Ensure that this version is compatible with the rest of your codebase and dependencies.23-31: This step uses the
get-diff-actionto get a diff of the specified file patterns. Ensure that these patterns cover all the files you want to include in the diff.
| # with: | ||
| # PATTERNS: | | ||
| # Makefile |
There was a problem hiding this comment.
These commented lines suggest that you might want to include Makefile and **/Makefile in the patterns for the get-diff-action. If these files are relevant, consider uncommenting these lines.
Description
Closes: XXX
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdmake lintandmake testReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking changeSummary by CodeRabbit
MsgServiceRouter.confixtool for managing configuration files.view,diff, andhomecommands inconfix.x/feegrant.x/upgrade.CHANGELOG.mdfiles.x/gov.x/evidence.x/feegrantkeeper.x/feegrant.v0.46.xline.CHANGELOG.mdfiles.comet.Infoas an argument to evidence inx/evidence.x/nft.