-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(docs): fix script for docs #18444
Conversation
Important Auto Review SkippedAuto reviews are disabled on base/target branches other than the default branch. Please add the base/target branch pattern to the list of additional branches to be reviewed in the settings. Please check the settings in the CodeRabbit UI or the To trigger a single review, invoke the TipsChat with CodeRabbit Bot (
|
if [ -d "${D}" ]; then | ||
MODDOC=docs/build/modules/$(echo $D | awk -F/ '{print $NF}') | ||
MODDOC=docs/docs/build/modules/$(echo $D | awk -F/ '{print $NF}') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
did a pr get backported that wasnt suppose to?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ive just looked into it and it doesnt seem like it, otherwise there could be a chance its been broken for a while
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm, now I dont think this will fix the issue in the docs-repo
we should test this form a fork, instead of merging to branches. We can change the repo in the docs repo to test things out |
Currently the script isnt working and is showing up with errors when run. This might be causing issues here #18436 and https://github.com/cosmos/cosmos-sdk-docs/actions/runs/6818872322/job/18545260045.
This may not resolve the issue on the docs repo but still needs to be fixed.
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
make lint
andmake test
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change