Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove gogoproto replace statements for v8 #167

Closed
Taztingo opened this issue Mar 11, 2024 · 3 comments
Closed

Remove gogoproto replace statements for v8 #167

Taztingo opened this issue Mar 11, 2024 · 3 comments
Assignees
@Reecepbcups
Labels
async-icq Label for items related to the async-icq module packet-forward-middleware Label for items related to the packet forward middleware

Comments

@Taztingo
Copy link
Contributor

I'm currently assisting the Provenance Blockchain in migrating to sdk 50. One step in this migration process is the ability to remove github.com/gogo/protobuf => github.com/regen-network/protobuf v1.3.3-alpha.regen.1 from go.mod since cosmos/gogoproto is being used. The Provenance Blockchain cannot remove this dependency because it was not removed from async-icq/v8. This ibc-app should be able to remove it since it is no longer needed.
@Taztingo Taztingo changed the title Remove gogoproto from async-icq/v8 Remove gogoproto replace statement from async-icq/v8 Mar 11, 2024
@Taztingo
Copy link
Contributor Author

Official documentation can be found here

This means you should replace all imports of github.com/gogo/protobuf to github.com/cosmos/gogoproto. This allows you to remove the replace directive replace github.com/gogo/protobuf => github.com/regen-network/protobuf v1.3.3-alpha.regen.1 from your go.mod file.

@Taztingo Taztingo mentioned this issue Mar 11, 2024
Merged
@Reecepbcups
Copy link
Member

Making note: I need to check PFM too

@Reecepbcups Reecepbcups changed the title Remove gogoproto replace statement from async-icq/v8 Remove gogoproto replace statements for v8 Mar 11, 2024
@Reecepbcups Reecepbcups self-assigned this Mar 11, 2024
@Reecepbcups Reecepbcups added packet-forward-middleware Label for items related to the packet forward middleware async-icq Label for items related to the async-icq module labels Mar 11, 2024
@Reecepbcups
Copy link
Member

Reecepbcups commented Mar 11, 2024 •
edited
Loading

we're good . Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Reecepbcups Reecepbcups

Labels
async-icq Label for items related to the async-icq module packet-forward-middleware Label for items related to the packet forward middleware
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Taztingo @Reecepbcups