Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IBCModuleV2 Transfer Application Spike #7510

Open
4 tasks
chatton opened this issue Oct 23, 2024 · 0 comments · Fixed by #7524
Open
4 tasks

IBCModuleV2 Transfer Application Spike #7510

chatton opened this issue Oct 23, 2024 · 0 comments · Fixed by #7524
Assignees

Comments

@chatton
Copy link
Contributor

chatton commented Oct 23, 2024

Summary

Spike a transfer IBCModuleV2 implementation.

Leaving a few thoughts about considerations I've had, decisions can be made when finalizing implementation

  • should transfer v2 code live in a new module directory, or just under module/transfer/v2
  • Do we need a MsgTransfer(V2)? I don't think so if we have MsgSendPacket and all the validation happens there.
  • Forwarding logic needs to be refactored, as in V1 we store a full packet, in V2 we are not providing the packet as an application callback argument. I think this can be out of the scope of this spike.
  • both ics20-v1 and ics20-v2 should be supported at the application level, same as existing transfer module.
  • testing library needs to be updated to account for sending tokens back and forth between chains using V1 and V2 transfer modules.

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
  • Estimate provided
@chatton chatton moved this to In progress in IBC-GO Eureka Oct 23, 2024
@chatton chatton self-assigned this Oct 23, 2024
@womensrights womensrights linked a pull request Nov 15, 2024 that will close this issue
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants