Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: query handlers are ignoring accumulate flag #7831

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

fix: query handlers are ignoring accumulate flag #7831

wants to merge 6 commits into from

Conversation

charymalloju
Copy link

@charymalloju charymalloju commented Jan 9, 2025 •
edited by gjermundgaraba
Loading

Description

closes: #7825

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against the correct branch (see CONTRIBUTING.md).
  • Linked to GitHub issue with discussion and accepted design, OR link to spec that describes this work.
  • Code follows the module structure standards and Go style guide.
  • Wrote unit and integration tests.
  • Updated relevant documentation (docs/).
  • Added relevant godoc comments.
  • Provide a conventional commit message to follow the repository standards.
  • Include a descriptive changelog entry when appropriate. This may be left to the discretion of the PR reviewers. (e.g. chores should be omitted from changelog)
  • Re-reviewed Files changed in the GitHub PR explorer.
  • Review SonarCloud Report in the comment section below once CI passes.

gjermundgaraba
gjermundgaraba requested changes Jan 11, 2025
View reviewed changes
Copy link
Contributor

@gjermundgaraba gjermundgaraba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this PR! This will be nice to get fixed.

I think the solution itself is correct, but I added some comments in the tests.

I have linked to the issue for the PR, in which I added one more location that has the same issue, so please fix that one and the test cases.

modules/core/02-client/keeper/grpc_query_test.go Outdated Show resolved Hide resolved
modules/core/02-client/keeper/grpc_query_test.go Show resolved Hide resolved
@AdityaSripal
Copy link
Member

Hi, thanks for the pr! do you have a link to another filtered paginate query that does something similar so we can compare to an existing query

@gjermundgaraba
Copy link
Contributor

@charymalloju, did you get a chance to look at the comment from Aditya above?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AdityaSripal AdityaSripal Awaiting requested review from AdityaSripal AdityaSripal is a code owner

@srdtrk srdtrk Awaiting requested review from srdtrk srdtrk is a code owner

@gjermundgaraba gjermundgaraba Awaiting requested review from gjermundgaraba gjermundgaraba is a code owner

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

query handlers are ignoring accumulate flag
3 participants
@charymalloju @AdityaSripal @gjermundgaraba