Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set a limit on timeout specified by user #104

Open
gjermundgaraba opened this issue Nov 16, 2024 · 3 comments
Open

Set a limit on timeout specified by user #104

gjermundgaraba opened this issue Nov 16, 2024 · 3 comments
Labels
needs discussion This issue needs more discussion before its implementation

Comments

@gjermundgaraba
Copy link
Contributor

As per #88 (comment) we should have some kind of limit on the timeout.

We need to figure out:

  1. What the timeout limit should be
  2. Where we should enforce it
@srdtrk
Copy link
Member

srdtrk commented Nov 18, 2024

The limit should be same as that of ibc-go. If there is no limit in ibc-go, then we don't need to have a limit either. However, we wanna consider a large limit (days) due to aggregation use case. Same goes for ibc-go

@gjermundgaraba
Copy link
Contributor Author

gjermundgaraba commented Nov 18, 2024

I think it makes sense to have a limit, especially as we move to seconds (and someone might by accident try to use nanoseconds). I think the limit can be relatively high, but should ideally error out if things get too crazy.

Input @AdityaSripal @womensrights?

@womensrights
Copy link

I think the limit set previously was 24 hours, I thought this was too high, but I wasn't thinking about aggregation, but assuming we would want to aggregate something like 25 - 30 packets, in the last 24 hours there were 11k+ transfers on cosmos hub, almost 39k on osmosis. I guess some of the smaller chains have 10s to 100s of transfers in 24 hours. I think this is reasonable, and can't imagine smaller chains having their own market maker for fast transfer, and then waiting 24 hours + for your packet to arrive doesn't make sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs discussion This issue needs more discussion before its implementation
Projects
Status: Backlog
Development

No branches or pull requests

3 participants