Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create a function to validate UnwrappedPacketData #30

Open
gjermundgaraba opened this issue Aug 12, 2024 · 1 comment
Open

Create a function to validate UnwrappedPacketData #30

gjermundgaraba opened this issue Aug 12, 2024 · 1 comment
Labels
good practices Good code practices

Comments

@gjermundgaraba
Copy link
Contributor

We are doing some validation of the ICS20Lib.UnwrappedPacketData struct multiple places. It would be good to have a single validation function that we can reuse.
@gjermundgaraba gjermundgaraba added enhancement Improvements good practices Good code practices and removed enhancement Improvements labels Aug 12, 2024
@gjermundgaraba gjermundgaraba mentioned this issue Aug 12, 2024
Merged
@srdtrk
Copy link
Member

srdtrk commented Aug 12, 2024

Maybe we should generalize this to other structs as well. Identifying which structs would need this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good practices Good code practices
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gjermundgaraba @srdtrk