Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

relayer: return better config unmarshalling errors #327

Open
4 tasks
Zygimantass opened this issue Feb 25, 2025 · 1 comment
Open
4 tasks

relayer: return better config unmarshalling errors #327

Zygimantass opened this issue Feb 25, 2025 · 1 comment
Labels
enhancement Improvements relayer Issues related to the relayer

Comments

@Zygimantass
Copy link
Contributor

Summary

Right now, if the config is malformed, the error messages are pretty vague, e.g.:

~/s/solidity-ibc-eureka  main  relayer start --config programs/relayer/config.example.json
2025-02-25T11:10:22.366784Z  INFO solidity_ibc_eureka_relayer::core::builder: Starting relayer... socket_addr=127.0.0.1:3000
Error: failed to parse config: Invalid string length

Use cases

This will make it easier for operators to debug issues with their configs.

Proposal

Return the exact field in the JSON config that is malformed

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
  • Estimate provided
@Zygimantass Zygimantass added the relayer Issues related to the relayer label Feb 25, 2025
@srdtrk srdtrk added the enhancement Improvements label Feb 25, 2025
@srdtrk
Copy link
Member

srdtrk commented Feb 25, 2025

This type of error would be associated with a fixed length string, such as a contract/wallet address. I agree with the need to improve

@mmsqe mmsqe mentioned this issue Feb 25, 2025
Closed
6 tasks
@github-project-automation github-project-automation bot moved this to Backlog in IBC Mar 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Improvements relayer Issues related to the relayer
Projects
IBC
Status: Backlog
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

imp(relayer): align config as toml for better parse error mmsqe/solidity-ibc-eureka
2 participants
@Zygimantass @srdtrk