Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to deal with union light client modifications #90

Open
gjermundgaraba opened this issue Nov 11, 2024 · 0 comments
Open

How to deal with union light client modifications #90

gjermundgaraba opened this issue Nov 11, 2024 · 0 comments

Comments

@gjermundgaraba
Copy link
Contributor

We have some small modifications to the union light client to make it work for our Solidity Eureka implementation.
The code we use for our e2e tests with those modifications are currently located in this branch: https://github.com/gjermundgaraba/union/tree/gjermund/eth-light-client-for-eureka

The changes are mostly around:

  • Using Merkle path v2 (union will likely need to make this change themselves soon as well, so might not be an issue)
  • TODO: Fill out the rest of the changes

The question is, where should those changes live? If possible, the ideal scenario might be that we upstream our changes to the union repo so that we don't have to maintain a fork, but if that is not possible, we need to consider where such a fork should live, and how to make the maintenance burden as light as possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Backlog
Development

No branches or pull requests

1 participant