Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update workflow files, versions, lint errors etc. #42

Merged
merged 4 commits into from
Oct 30, 2024

Conversation

cosnicolaou
Copy link
Owner

@cosnicolaou cosnicolaou commented Oct 28, 2024

This PR addresses gosec's G115 complaints with //#nosec and minor code changes. The comments explain why I believe they are false positives.

github workflows are also updated.

@cosnicolaou cosnicolaou changed the title chore: update workflow files, lint errors etc. chore: update workflow files, versions, lint errors etc. Oct 28, 2024
@cosnicolaou cosnicolaou requested a review from klauspost October 29, 2024 18:41
Copy link
Collaborator

@klauspost klauspost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would probably have just disabled the check, because I'm lazy. but lgtm 👍🏼

@cosnicolaou cosnicolaou merged commit 431811f into main Oct 30, 2024
6 checks passed
@klauspost klauspost deleted the fix-lint-update-goversions branch October 31, 2024 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants