Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AuthHandler doc comment "default" bucket safety tips #64

Open
steveyen opened this issue Sep 4, 2015 · 0 comments
Open

AuthHandler doc comment "default" bucket safety tips #64

steveyen opened this issue Sep 4, 2015 · 0 comments

Comments

@steveyen
Copy link
Member

steveyen commented Sep 4, 2015

Originally from... couchbaselabs/cbgt#32

Doc improvement request, related to AuthHandler / pools.go:

// AuthHandler is a callback that gets the auth username and password
// for the given bucket.
type AuthHandler interface {
GetCredentials() (string, string, string)
}

"Should get an upgrade in the comment that specs out the contract "if using the 'default' bucket, the username should be 'default'". Either that or the more generic "the username returned by this should never be empty"."

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant