Data race detected in go-couchbase/tap.go

[tleyden]

Spun out of couchbase/sync_gateway#1400

Using go-couchbase commit ac7dc18:

sg3/sync_gateway_error.log:==================
sg3/sync_gateway_error.log:WARNING: DATA RACE
sg3/sync_gateway_error.log:Read by goroutine 48:
sg3/sync_gateway_error.log:  github.com/couchbase/go-couchbase.(*TapFeed).closeNodeFeeds()
sg3/sync_gateway_error.log:      /home/centos/sync_gateway/src/github.com/couchbase/go-couchbase/tap.go:121 +0x37
sg3/sync_gateway_error.log:  github.com/couchbase/go-couchbase.(*TapFeed).Close()
sg3/sync_gateway_error.log:      /home/centos/sync_gateway/src/github.com/couchbase/go-couchbase/tap.go:135 +0x98
sg3/sync_gateway_error.log:  github.com/couchbase/sync_gateway/base.(*couchbaseFeedImpl).Close()
sg3/sync_gateway_error.log:      <autogenerated>:1 +0x61
sg3/sync_gateway_error.log:  github.com/couchbase/sync_gateway/db.(*changeListener).Stop()
sg3/sync_gateway_error.log:      /home/centos/sync_gateway/src/github.com/couchbase/sync_gateway/db/change_listener.go:82 +0x77
sg3/sync_gateway_error.log:  github.com/couchbase/sync_gateway/db.(*DatabaseContext).Close()
sg3/sync_gateway_error.log:      /home/centos/sync_gateway/src/github.com/couchbase/sync_gateway/db/database.go:262 +0xa6
sg3/sync_gateway_error.log:  github.com/couchbase/sync_gateway/rest.(*ServerContext)._removeDatabase()
sg3/sync_gateway_error.log:      /home/centos/sync_gateway/src/github.com/couchbase/sync_gateway/rest/server_context.go:980 +0x2a7
sg3/sync_gateway_error.log:  github.com/couchbase/sync_gateway/rest.(*ServerContext).ReloadDatabaseFromConfig()
sg3/sync_gateway_error.log:      /home/centos/sync_gateway/src/github.com/couchbase/sync_gateway/rest/server_context.go:528 +0xbf
sg3/sync_gateway_error.log:  github.com/couchbase/sync_gateway/rest.(*handler).handleDbOnline.func1()
sg3/sync_gateway_error.log:      /home/centos/sync_gateway/src/github.com/couchbase/sync_gateway/rest/admin_api.go:87 +0x24f

Full logs in context