Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non-async calls should be put in a blocking context #172

Open
dguo-coursera opened this issue Feb 22, 2017 · 0 comments
Open

Non-async calls should be put in a blocking context #172

dguo-coursera opened this issue Feb 22, 2017 · 0 comments

Comments

@dguo-coursera
Copy link
Contributor

I believe it's being wrapped inside a Future.successful

We should instead use a blocking context:
http://docs.scala-lang.org/overviews/core/futures.html#in_a_future

This allows users to customize how blocking calls are handled. For Coursera, this allows the pool to add more parallelism via ManagedBlocker.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant