Skip to content

Commit 4c42d85

Browse files
committed
fix bug in plan copy
1 parent fda9326 commit 4c42d85

File tree

1 file changed

+6
-5
lines changed

1 file changed

+6
-5
lines changed

redistricting/services/basebuilder.py

+6-5
Original file line numberDiff line numberDiff line change
@@ -39,6 +39,7 @@
3939
DeviationType,
4040
RdsDataField,
4141
RdsField,
42+
RdsGeoField,
4243
RdsPlan
4344
)
4445
from ..utils import (
@@ -402,13 +403,13 @@ def appendGeoField(self, field: str, caption: str = None) -> Self:
402403
...
403404

404405
@overload
405-
def appendGeoField(self, field: RdsField) -> Self:
406+
def appendGeoField(self, field: RdsGeoField) -> Self:
406407
...
407408

408409
def appendGeoField(self, field, caption=None):
409410
if isinstance(field, str):
410-
field = RdsField(self._geoLayer, field, caption)
411-
elif not isinstance(field, RdsField):
411+
field = RdsGeoField(self._geoLayer, field, caption)
412+
elif not isinstance(field, RdsGeoField):
412413
raise ValueError(
413414
tr('Attempt to add invalid field {field!r} to plan {plan}').
414415
format(field=field, plan=self._name)
@@ -425,7 +426,7 @@ def appendGeoField(self, field, caption=None):
425426
return self
426427

427428
@overload
428-
def removeGeoField(self, field: RdsField) -> Self:
429+
def removeGeoField(self, field: RdsGeoField) -> Self:
429430
...
430431

431432
@overload
@@ -440,7 +441,7 @@ def removeGeoField(self, field) -> Self:
440441
if isinstance(field, RdsField):
441442
if not field in self._geoFields:
442443
raise ValueError(
443-
tr('Could not remove field {field}. RdsField not found in plan {plan}.').
444+
tr('Could not remove field {field}. Field object not found in plan {plan}.').
444445
format(field=field.field, plan=self._name)
445446
)
446447
elif isinstance(field, str):

0 commit comments

Comments
 (0)